Skip to content

Use global lane for maildesk sender previews #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rogu3bear merged 1 commit into from
Jul 1, 2026
Merged

Use global lane for maildesk sender previews #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/cf_maildesk_cf_lifecycle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ def sender_readback_available(sender: dict[str, Any]) -> bool:
def sender_domain_enable_plan_command(domain: str) -> str:
quoted_domain = shlex.quote(domain)
return (
"cfctl apply sender_domain enable "
"CF_TOKEN_LANE=global cfctl apply sender_domain enable "
f"--zone {quoted_domain} --name {quoted_domain} --plan"
)

Expand Down
2 changes: 1 addition & 1 deletion scripts/verify_maildesk_cf_contract.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ jq -e '
and .readiness.mail_ready == false
and (.drift_classes | index("sender_domain_drift")) != null
and (.drift_classes | index("provider_status_unavailable")) == null
and any(.plan.operations[]; .surface == "sender_domain" and .preview_command == "cfctl apply sender_domain enable --zone example.com --name example.com --plan" and .blocked == null)
and any(.plan.operations[]; .surface == "sender_domain" and .preview_command == "CF_TOKEN_LANE=global cfctl apply sender_domain enable --zone example.com --name example.com --plan" and .blocked == null)
' "${unverified_sender_artifact_path}" >/dev/null || die "unverified sender-domain drift contract did not match"

cfctl_output="$(
Expand Down
Loading