Use global lane for maildesk sender previews#34
Merged
Conversation
Sender-domain readback for maildesk already uses the global Cloudflare lane because the dev lane cannot resolve every private zone. The generated component preview commands need the same lane, otherwise the composite plan advertises previews that fail before writing an operation artifact. Keep the change at the lifecycle command generator and pin it with the maildesk contract fixture.
Owner
Author
|
@codex Please review the sender-domain preview lane change. I am least certain whether global should be hardcoded for every maildesk sender-domain component preview, but it matches current readback and is what makes private zone dry-runs resolve. |
Owner
Author
|
Local proof is green: maildesk lifecycle contract, py_compile, diff check, static contract, private composite plan, and 14/14 private sender-domain component dry-run previews. The GitHub static-contract job failed before runner steps/logs were recorded, matching the existing cfctl Actions startup-failure pattern on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CF_TOKEN_LANE=global.Test plan
bash scripts/verify_maildesk_cf_contract.shpython3 -m py_compile scripts/cf_maildesk_cf_lifecycle.pygit diff --check./scripts/verify_static_contract.sh/Users/star/dev/star-maildesk-cf:cfctl maildesk-cf provision --file config/desired-state.local.json --planproduced 14/14 global-lane sender-domain previews/Users/star/dev/star-maildesk-cf: executed 14/14 sender-domain preview commands as--plan; all returnedok=true,performed=false,plan_mode=true, and operation idsRisk / review focus
--ack-planand does not mutate Cloudflare.