chore: sync from monorepo @46bbacc#41
Conversation
📝 WalkthroughWalkthroughThis PR updates NuGet dependency versions across the resq-software/dotnet-sdk solution. It bumps central package versions for gRPC and Microsoft.Extensions libraries in Directory.Packages.props, then adds explicit package references with version overrides to individual projects to control resolved versions. ChangesDependency Version Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
There was a problem hiding this comment.
Code Review
This pull request updates several dependency versions in the central package management file, including gRPC, Microsoft Extensions, and System.Text.Json. Review feedback highlights critical issues where Microsoft.Extensions.Logging.Abstractions was downgraded to version 8.0.3 in specific projects, contradicting the central version 10.0.7 and risking dependency conflicts. Additionally, a redundant version override for System.Text.Json was identified, and indentation corrections were requested to maintain consistency across project files.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/ResQ.Blockchain/ResQ.Blockchain.csproj (1)
12-12: ⚡ Quick winRemove redundant
VersionOverride.The
VersionOverride="9.0.15"matches the centrally-managed version inDirectory.Packages.props(line 27). When the override matches the central version, it adds no value and creates maintenance overhead by requiring updates in two places.♻️ Proposed fix to remove redundant override
- <PackageReference Include="System.Text.Json" VersionOverride="9.0.15" /> + <PackageReference Include="System.Text.Json" />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ResQ.Blockchain/ResQ.Blockchain.csproj` at line 12, The PackageReference for System.Text.Json currently includes a redundant VersionOverride="9.0.15" that duplicates the centrally-managed version; remove the VersionOverride attribute from the PackageReference element (the line containing PackageReference Include="System.Text.Json" VersionOverride="9.0.15") so the project relies on the version declared in Directory.Packages.props.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ResQ.Protocols/ResQ.Protocols.csproj`:
- Line 12: The project overrides Microsoft.Extensions.Logging.Abstractions to
8.0.3 (PackageReference Include="Microsoft.Extensions.Logging.Abstractions"
VersionOverride="8.0.3") which downgrades the centrally-defined 10.0.7 and
fragments the solution; either align the versions by updating
Directory.Packages.props to 8.0.3 if that downgrade is required for
compatibility, or remove the VersionOverride and keep the central 10.0.7; if
leaving the override in ResQ.Protocols and resq-core, add an XML comment in each
.csproj near the PackageReference explaining the compatibility constraint (e.g.,
netstandard2.1 or tooling requirement) and reference the exact PackageReference
symbol so future maintainers understand why VersionOverride="8.0.3" is present.
---
Nitpick comments:
In `@packages/ResQ.Blockchain/ResQ.Blockchain.csproj`:
- Line 12: The PackageReference for System.Text.Json currently includes a
redundant VersionOverride="9.0.15" that duplicates the centrally-managed
version; remove the VersionOverride attribute from the PackageReference element
(the line containing PackageReference Include="System.Text.Json"
VersionOverride="9.0.15") so the project relies on the version declared in
Directory.Packages.props.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0f535cde-7822-47a7-9ebb-37cd7c19a907
📒 Files selected for processing (5)
Directory.Packages.propsResQ.Blockchain/ResQ.Blockchain.csprojpackages/ResQ.Blockchain/ResQ.Blockchain.csprojpackages/ResQ.Protocols/ResQ.Protocols.csprojresq-core/ResQ.Core.csproj
Automated sync from resq-software/resQ@
46bbacc.Review before merging — direct pushes to standalone repos are preserved.
Summary by CodeRabbit