Skip to content

chore: sync from monorepo @46bbacc#41

Merged
WomB0ComB0 merged 2 commits into
mainfrom
sync/monorepo-46bbacc
Jun 10, 2026
Merged

chore: sync from monorepo @46bbacc#41
WomB0ComB0 merged 2 commits into
mainfrom
sync/monorepo-46bbacc

Conversation

@WomB0ComB0

@WomB0ComB0 WomB0ComB0 commented May 2, 2026

Copy link
Copy Markdown
Member

Automated sync from resq-software/resQ@46bbacc.

Review before merging — direct pushes to standalone repos are preserved.

Summary by CodeRabbit

  • Chores
    • Updated gRPC and Microsoft Extensions packages to the latest versions for improved stability.
    • Added explicit package dependency references across projects for enhanced consistency and maintainability.

@coderabbitai

coderabbitai Bot commented May 2, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates NuGet dependency versions across the resq-software/dotnet-sdk solution. It bumps central package versions for gRPC and Microsoft.Extensions libraries in Directory.Packages.props, then adds explicit package references with version overrides to individual projects to control resolved versions.

Changes

Dependency Version Updates

Layer / File(s) Summary
Central package version updates
Directory.Packages.props
Grpc.Net.Client updated to 2.80.0; Microsoft.Extensions.Http, Microsoft.Extensions.Http.Polly, Microsoft.Extensions.Logging.Abstractions, and Microsoft.Extensions.Options all updated to 10.0.7; System.Text.Json updated to 9.0.15.
Project-specific package references and version overrides
ResQ.Blockchain/ResQ.Blockchain.csproj, packages/ResQ.Blockchain/ResQ.Blockchain.csproj, packages/ResQ.Protocols/ResQ.Protocols.csproj, resq-core/ResQ.Core.csproj
ResQ.Blockchain and packages/ResQ.Blockchain add explicit System.Text.Json references (the latter with VersionOverride 9.0.15); packages/ResQ.Protocols and resq-core add explicit Microsoft.Extensions.Logging.Abstractions references with VersionOverride 8.0.3.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • resq-software/dotnet-sdk#37: Updates Directory.Packages.props package versions for Microsoft.Extensions.* HTTP/logging/options stack dependencies.

Poem

🐰 Hop along with version bumps so fine,
Grpc hops to 2.80, Extensions align,
System.Text.Json shines in 9.0.15,
Project overrides ensure versions are set right,
Dependencies dance in perfect delight! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the pull request as a monorepo synchronization at a specific commit, which aligns with the actual changes being dependency updates across multiple project files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/monorepo-46bbacc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security

socket-security Bot commented May 2, 2026

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependency versions in the central package management file, including gRPC, Microsoft Extensions, and System.Text.Json. Review feedback highlights critical issues where Microsoft.Extensions.Logging.Abstractions was downgraded to version 8.0.3 in specific projects, contradicting the central version 10.0.7 and risking dependency conflicts. Additionally, a redundant version override for System.Text.Json was identified, and indentation corrections were requested to maintain consistency across project files.

Comment thread packages/ResQ.Protocols/ResQ.Protocols.csproj
Comment thread resq-core/ResQ.Core.csproj
Comment thread packages/ResQ.Blockchain/ResQ.Blockchain.csproj

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/ResQ.Blockchain/ResQ.Blockchain.csproj (1)

12-12: ⚡ Quick win

Remove redundant VersionOverride.

The VersionOverride="9.0.15" matches the centrally-managed version in Directory.Packages.props (line 27). When the override matches the central version, it adds no value and creates maintenance overhead by requiring updates in two places.

♻️ Proposed fix to remove redundant override
-  <PackageReference Include="System.Text.Json" VersionOverride="9.0.15" />
+  <PackageReference Include="System.Text.Json" />
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/ResQ.Blockchain/ResQ.Blockchain.csproj` at line 12, The
PackageReference for System.Text.Json currently includes a redundant
VersionOverride="9.0.15" that duplicates the centrally-managed version; remove
the VersionOverride attribute from the PackageReference element (the line
containing PackageReference Include="System.Text.Json" VersionOverride="9.0.15")
so the project relies on the version declared in Directory.Packages.props.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/ResQ.Protocols/ResQ.Protocols.csproj`:
- Line 12: The project overrides Microsoft.Extensions.Logging.Abstractions to
8.0.3 (PackageReference Include="Microsoft.Extensions.Logging.Abstractions"
VersionOverride="8.0.3") which downgrades the centrally-defined 10.0.7 and
fragments the solution; either align the versions by updating
Directory.Packages.props to 8.0.3 if that downgrade is required for
compatibility, or remove the VersionOverride and keep the central 10.0.7; if
leaving the override in ResQ.Protocols and resq-core, add an XML comment in each
.csproj near the PackageReference explaining the compatibility constraint (e.g.,
netstandard2.1 or tooling requirement) and reference the exact PackageReference
symbol so future maintainers understand why VersionOverride="8.0.3" is present.

---

Nitpick comments:
In `@packages/ResQ.Blockchain/ResQ.Blockchain.csproj`:
- Line 12: The PackageReference for System.Text.Json currently includes a
redundant VersionOverride="9.0.15" that duplicates the centrally-managed
version; remove the VersionOverride attribute from the PackageReference element
(the line containing PackageReference Include="System.Text.Json"
VersionOverride="9.0.15") so the project relies on the version declared in
Directory.Packages.props.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0f535cde-7822-47a7-9ebb-37cd7c19a907

📥 Commits

Reviewing files that changed from the base of the PR and between 671b0ee and 92bcf76.

📒 Files selected for processing (5)
  • Directory.Packages.props
  • ResQ.Blockchain/ResQ.Blockchain.csproj
  • packages/ResQ.Blockchain/ResQ.Blockchain.csproj
  • packages/ResQ.Protocols/ResQ.Protocols.csproj
  • resq-core/ResQ.Core.csproj

Comment thread packages/ResQ.Protocols/ResQ.Protocols.csproj
@WomB0ComB0 WomB0ComB0 merged commit 3b7bc7a into main Jun 10, 2026
35 checks passed
@WomB0ComB0 WomB0ComB0 deleted the sync/monorepo-46bbacc branch June 10, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant