-
Notifications
You must be signed in to change notification settings - Fork 349
chore: update ArgoCD validation rules and bump dependencies #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: update ArgoCD validation rules and bump dependencies #1061
Conversation
Signed-off-by: akhil nittala <nakhil@redhat.com>
b509227 to
5e4244f
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: svghadi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
|
@akhilnittala: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
What does this PR do / why we need it:
When both sso and oidc config is provided in argocd, we are not rejecting the request. so with this pr changes, we have implemented validation which rejects the request with argocd CR having both sso and oidc configuration.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/GITOPS-8560
Fixes #?
https://issues.redhat.com/browse/GITOPS-8560
Test acceptance criteria:
How to test changes / Special notes to the reviewer: