Skip to content

COVERITY TEST. DO NOT MERGE #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snampo768 wants to merge 1 commit into from
Closed

COVERITY TEST. DO NOT MERGE #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ add_library(${TARGET}
${SOURCES}
)

target_compile_options(${TARGET} PRIVATE -Wno-error=format)

if(ENABLE_TESTS)
target_compile_options(${TARGET} PRIVATE --coverage -g -O0 -fno-inline)
target_link_options(${TARGET} PRIVATE --coverage)
Expand Down
2 changes: 2 additions & 0 deletions src/metrics_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "json_types/common.h"
#include "json_types/metrics.h"
#include <firebolt/json_types.h>
#include <stdio.h>

namespace Firebolt::Metrics
{
Expand Down Expand Up @@ -55,6 +56,7 @@
{
parameters["agePolicy"] = Firebolt::JSON::toString(Firebolt::JsonData::AgePolicyEnum, *agePolicy);
}
printf("Test coverity workflow %s\n");

Check warning

Code scanning / Coverity

Printf arg count mismatch Warning

PW.TOO_FEW_PRINTF_ARGS: the format string requires additional arguments

Check warning

Code scanning / Coverity

Missing argument to printf format specifier Warning

PRINTF_ARGS: No argument for format specifier "%s".
return helper_.invoke("Metrics.startContent", parameters);
}

Expand Down
Loading