COVERITY TEST. DO NOT MERGE#77
Closed
snampo768 wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to intentionally introduce a format-string issue and then suppress related compiler enforcement, likely to exercise a Coverity/static-analysis workflow (per title/description).
Changes:
- Added a
printfcall inMetricsImpl::startContent()with an invalid format string usage. - Added a build flag to disable
-Werrorpromotion for-Wformatwarnings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/metrics_impl.cpp |
Adds a debug printf (currently undefined behavior due to missing %s argument) and the associated C stdio include. |
src/CMakeLists.txt |
Disables -Werror=format, weakening compiler diagnostics for format-string issues. |
| { | ||
| parameters["agePolicy"] = Firebolt::JSON::toString(Firebolt::JsonData::AgePolicyEnum, *agePolicy); | ||
| } | ||
| printf("Test coverity workflow %s\n"); |
| #include "json_types/common.h" | ||
| #include "json_types/metrics.h" | ||
| #include <firebolt/json_types.h> | ||
| #include <stdio.h> |
| ${SOURCES} | ||
| ) | ||
|
|
||
| target_compile_options(${TARGET} PRIVATE -Wno-error=format) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| parameters["agePolicy"] = Firebolt::JSON::toString(Firebolt::JsonData::AgePolicyEnum, *agePolicy); | ||
| } | ||
| printf("Test coverity workflow %s\n"); |
| { | ||
| parameters["agePolicy"] = Firebolt::JSON::toString(Firebolt::JsonData::AgePolicyEnum, *agePolicy); | ||
| } | ||
| printf("Test coverity workflow %s\n"); |
Author
|
Close test PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COVERITY TEST. DO NOT MERGE