-
Notifications
You must be signed in to change notification settings - Fork 10
Remove intelligent control input sliders from scenarios #1583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This migration causes minor changes in comparison to beta, see the ii3050v2 NT Leadership scenario in which both removed sliders where set to 95%: I personally don't see how we could mitigate these changes, since there are no other sliders that influence the useful demand of lighting in the buildings sector. Since these changes are generally small, I feel that no extra effort is required. |
|
This pull request has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future. |
8fe5084 to
c74dbab
Compare
|
I've updated the migration file name to be the most recent one. I agree with the conclusion that there's no way to account for the settings in the intelligent light control inputs with I migration. So the migration should just only remove the inputs from the scenarios. |
|
Added @louispt1 as a functional reviewer. |
kndehaan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as it should.
|
The migration will be altered, as the work for quintel/etmodel#4631 will be taken up as well, which will affect the migration. |


This PR solves quintel/etmodel#4490 by removing the intelligent control lighting inputs in the scenarios
Goes with: