Arm backend: Update a8w4 _get_dtype_count to account for groups #16701
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When using groups, we need to update the count layers. Signed-off-by: Saoirse Stewart <saoirse.stewart@arm.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16701
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f29aded with merge base 176c162 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label 'partner: arm' |
pytorch-bot
bot
added
the
partner: arm
zingo
approved these changes
Jan 20, 2026
Collaborator
zingo
left a comment
zingo
left a comment
There was a problem hiding this comment.
OK to merge is Arm tests pass!
Collaborator
|
Rebased to re-test after a cortex-m fix was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using groups, we need to update the count for grouped Conv2D layers.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai