Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Dec 26, 2025

Stack from ghstack (oldest at bottom):

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

Key components:

  1. factory/Empty.h - Factory functions for creating empty tensors:

    • empty_strided(sizes, strides, dtype, device) - Creates tensor with explicit sizes/strides
    • empty(sizes, dtype, device) - Creates contiguous tensor (auto-computes row-major strides)
    • empty(initializer_list, dtype, device) - Convenience overload for inline size specification
    • empty_like(tensor) - Creates empty tensor with same metadata as another tensor
  2. core/Storage.h - Added new_storage() helper function:

    • Computes required storage bytes from sizes, strides, and dtype
    • Allocates and returns a new owning Storage instance

Differential Revision: D89820292

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16398

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ded7570 with merge base 4f8dbde (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…tensors"

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
…tensors"

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
…tensors"

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
…tensors"

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
…tensors"

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)

[ghstack-poisoned]
@meta-codesync meta-codesync bot merged commit d6fed67 into gh/gasoonjia/77/base Jan 21, 2026
170 checks passed
@meta-codesync meta-codesync bot deleted the gh/gasoonjia/77/head branch January 21, 2026 05:57
Gasoonjia added a commit that referenced this pull request Jan 21, 2026
…6730)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #16398 by
@Gasoonjia
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/77/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/77/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/77/orig
Differential Revision:
[D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)
@diff-train-skip-merge

Co-authored-by: gasoonjia <gasoonjia@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants