Skip to content

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #16398 by @Gasoonjia
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/gasoonjia/77/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/77/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/gasoonjia/77/orig
Differential Revision: D89820292
@diff-train-skip-merge

Pull Request resolved: #16398

This diff adds factory functions to create SlimTensor instances with allocated storage for better usage.

**Key components:**

1. **`factory/Empty.h`** - Factory functions for creating empty tensors:
   - `empty_strided(sizes, strides, dtype, device)` - Creates tensor with explicit sizes/strides
   - `empty(sizes, dtype, device)` - Creates contiguous tensor (auto-computes row-major strides)
   - `empty(initializer_list, dtype, device)` - Convenience overload for inline size specification
   - `empty_like(tensor)` - Creates empty tensor with same metadata as another tensor

2. **`core/Storage.h`** - Added `new_storage()` helper function:
   - Computes required storage bytes from sizes, strides, and dtype
   - Allocates and returns a new owning Storage instance
ghstack-source-id: 334622015
@exported-using-ghexport

Differential Revision: [D89820292](https://our.internmc.facebook.com/intern/diff/D89820292/)
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16730

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 140 Pending

As of commit ef540f1 with merge base 4f8dbde (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia Gasoonjia merged commit 3069a11 into main Jan 21, 2026
152 of 154 checks passed
@Gasoonjia Gasoonjia deleted the gh/gasoonjia/77/orig branch January 21, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants