Skip to content

ci: use Powershell 7+ for Windows workflow #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 3 commits into from
Mar 5, 2026
+16 −25
Merged

ci: use Powershell 7+ for Windows workflow #2236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7160834
ci: use Powershell 7+ for Windows workflow
dunglas Mar 5, 2026
c0e1d46
fix workflow path
dunglas Mar 5, 2026
6955e38
fix workflow exclude rules
dunglas Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 16 additions & 25 deletions .github/workflows/windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
name: Build Windows release

concurrency:
Expand All @@ -8,21 +9,15 @@ on:
pull_request:
branches:
- main
paths:
- "docker-bake.hcl"
- "vcpkg.json"
- ".github/workflows/static.yaml"
- "**cgo.go"
- "**Dockerfile"
- "**.c"
- "**.h"
- "**.sh"
- "**.stub.php"
paths-ignore:
- "docs/**"
push:
branches:
- main
tags:
- v*.*.*
paths-ignore:
- "docs/**"
workflow_dispatch:
inputs:
#checkov:skip=CKV_GHA_7
Expand All @@ -46,10 +41,6 @@ env:
jobs:
build:
runs-on: windows-latest
defaults:
run:
shell: powershell

steps:
- name: Configure Git
run: |
Expand All @@ -72,7 +63,7 @@ jobs:
$frankenphpVersion = $env:GITHUB_SHA
}

echo "FRANKENPHP_VERSION=$frankenphpVersion" | Out-File -FilePath $env:GITHUB_ENV -Append
"FRANKENPHP_VERSION=$frankenphpVersion" >> $env:GITHUB_ENV

- name: Setup Go
uses: actions/setup-go@v6
Expand Down Expand Up @@ -102,7 +93,7 @@ jobs:

- name: Download PHP
run: |
$webContent = Invoke-WebRequest -Uri $env:PHP_DOWNLOAD_BASE -UseBasicParsing
$webContent = Invoke-WebRequest -Uri $env:PHP_DOWNLOAD_BASE
$links = $webContent.Links.Href | Where-Object { $_ -match "php-\d+\.\d+\.\d+-Win32-vs17-x64\.zip$" }

if (-not $links) { throw "Could not find PHP zip files at $env:PHP_DOWNLOAD_BASE" }
Expand All @@ -112,14 +103,14 @@ jobs:
$version = if ($latestFile -match '(\d+\.\d+\.\d+)') { $matches[1] }
Write-Host "Detected latest PHP version: $version"

"PHP_VERSION=$version" | Out-File -FilePath $env:GITHUB_ENV -Append
"PHP_VERSION=$version" >> $env:GITHUB_ENV

$phpZip = "php-$version-Win32-vs17-x64.zip"
$develZip = "php-devel-pack-$version-Win32-vs17-x64.zip"

$dirName = "frankenphp-$env:FRANKENPHP_VERSION-php-$version-Win32-vs17-x64"

echo "DIR_NAME=$dirName" | Out-File -FilePath $env:GITHUB_ENV -Append
"DIR_NAME=$dirName" >> $env:GITHUB_ENV

Invoke-WebRequest -Uri "$env:PHP_DOWNLOAD_BASE/$phpZip" -OutFile "$env:TEMP\php.zip"
Expand-Archive -Path "$env:TEMP\php.zip" -DestinationPath "$env:GITHUB_WORKSPACE\$dirName"
Expand All @@ -134,13 +125,13 @@ jobs:
$phpBin = "$env:GITHUB_WORKSPACE\$env:DIR_NAME"
$phpDevel = "$env:GITHUB_WORKSPACE\php-devel\php-$env:PHP_VERSION-devel-vs17-x64"

echo "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\bin" | Out-File -FilePath $env:GITHUB_PATH -Append
echo "$vcpkgRoot\bin" | Out-File -FilePath $env:GITHUB_PATH -Append
echo "$watcherRoot" | Out-File -FilePath $env:GITHUB_PATH -Append
echo "$phpBin" | Out-File -FilePath $env:GITHUB_PATH -Append
"C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\bin" >> $env:GITHUB_PATH
"$vcpkgRoot\bin" >> $env:GITHUB_PATH
"$watcherRoot" >> $env:GITHUB_PATH
"$phpBin" >> $env:GITHUB_PATH

echo "CGO_CFLAGS=-DFRANKENPHP_VERSION=$env:FRANKENPHP_VERSION -I$vcpkgRoot\include -I$watcherRoot -I$phpDevel\include -I$phpDevel\include\main -I$phpDevel\include\TSRM -I$phpDevel\include\Zend -I$phpDevel\include\ext" | Out-File -FilePath $env:GITHUB_ENV -Append
echo "CGO_LDFLAGS=-L$vcpkgRoot\lib -lbrotlienc -L$watcherRoot -llibwatcher-c -L$phpBin -L$phpDevel\lib -lphp8ts -lphp8embed" | Out-File -FilePath $env:GITHUB_ENV -Append
"CGO_CFLAGS=-DFRANKENPHP_VERSION=$env:FRANKENPHP_VERSION -I$vcpkgRoot\include -I$watcherRoot -I$phpDevel\include -I$phpDevel\include\main -I$phpDevel\include\TSRM -I$phpDevel\include\Zend -I$phpDevel\include\ext" >> $env:GITHUB_ENV
"CGO_LDFLAGS=-L$vcpkgRoot\lib -lbrotlienc -L$watcherRoot -llibwatcher-c -L$phpBin -L$phpDevel\lib -lphp8ts -lphp8embed" >> $env:GITHUB_ENV

- name: Embed Windows icon and metadata
working-directory: frankenphp\caddy\frankenphp
Expand Down Expand Up @@ -174,7 +165,7 @@ jobs:
Translation = @{ LangID = 9; CharsetID = 1200 }
}
} | ConvertTo-Json -Depth 10
[System.IO.File]::WriteAllText("versioninfo.json", $json, [System.Text.Encoding]::Default)
$json | Set-Content "versioninfo.json"

goversioninfo -64 -icon ..\..\frankenphp.ico versioninfo.json -o resource.syso

Expand Down