Skip to content

ci: use Powershell 7+ for Windows workflow#2236

Merged
dunglas merged 3 commits intomainfrom
ci/pwsh
Mar 5, 2026
Merged

ci: use Powershell 7+ for Windows workflow#2236
dunglas merged 3 commits intomainfrom
ci/pwsh

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Mar 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 5, 2026 15:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the explicit shell: powershell (Windows PowerShell 5.1) default from the Windows CI workflow, allowing it to use the GitHub Actions default of pwsh (PowerShell 7+). The accompanying changes update idioms that were specific to Windows PowerShell 5.1 to their cleaner PowerShell 7+ equivalents.

Changes:

  • Removed the defaults.run.shell: powershell block, switching to pwsh (PowerShell 7+) as the default shell
  • Replaced echo "..." | Out-File -FilePath ... -Append with the simpler "..." >> $env:GITHUB_ENV / $env:GITHUB_PATH redirection syntax and removed the unnecessary -UseBasicParsing flag from Invoke-WebRequest
  • Replaced [System.IO.File]::WriteAllText(...) with Set-Content for writing the JSON metadata file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dunglas dunglas merged commit 73c7b2e into main Mar 5, 2026
@dunglas dunglas deleted the ci/pwsh branch March 5, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants