GRPH-87 - Choice of range proof params in cli wallet reveals transaction magnitude to very narrow range for Blinded transfers#112
Open
srpatel19590 wants to merge 1 commit intodevelopfrom
Open
Conversation
Author
|
@bobinson I will resolve conflicts here once you merge GRPH-3 |
|
I think we can close this one and add a new one where only the code related to the fix is present. This code can be found at https://github.com/bitshares/bitshares-core/pull/1117/files |
bobinson
approved these changes
Sep 12, 2019
bobinson
left a comment
bobinson
left a comment
There was a problem hiding this comment.
lets make a clean PR as per @oxarbitrage 's suggestion. Sorry about the rework ...
srpatel19590
force-pushed
the
feature/GRPH-87
branch
from
2fcbb3c to
f1b3ae7
Compare
Author
|
@bobinson This PR is updated as per your request. |
oxarbitrage
suggested changes
Sep 13, 2019
There was a problem hiding this comment.
Test is failing.
I added a log here: https://github.com/oxarbitrage/logs/blob/master/pp_pull112
Author
|
It will work once you merge #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referrence: bitshares/bitshares-core#480