[GRPH-3] port cli tests from bitshares to Peerplays #105
[GRPH-3] port cli tests from bitshares to Peerplays #105srpatel19590 wants to merge 1 commit intodevelopfrom
Conversation
|
This is the same as #98 |
|
@oxarbitrage GRPH-3 was assigned to me. I've raised this PR as part of it. Moreover, it covers more tests compare to #98 |
|
@srpatel19590 - Which are the additional tests that you mentioned ? |
|
@bobinson Here is the list of additional tests.
|
bobinson
changed the title
| */ | ||
| bool load_wallet_file(string wallet_filename = ""); | ||
|
|
||
| /** Quitting from BitShares wallet. |
There was a problem hiding this comment.
@srpatel19590 - This should be Peerplays wallet
tests/CMakeLists.txt
Outdated
| file(GLOB CLI_SOURCES "cli/*.cpp") | ||
| add_executable( cli_test ${CLI_SOURCES} ) | ||
| if(WIN32) | ||
| list(APPEND PLATFORM_SPECIFIC_LIBS ws2_32) |
There was a problem hiding this comment.
@srpatel19590 "PLATFORM_SPECIFIC_LIBS ws2_32" -- what are these libraries ?
There was a problem hiding this comment.
These are windows socket lib. Additionally added to PLATFORM_SPECIFIC_LIBS when the target is windows.
There was a problem hiding this comment.
@srpatel19590 - provide specific details. ie link, versions etc.
There was a problem hiding this comment.
@bobinson By compiling with Visual Studio 2017 and 2015 Update 1, the required ws2_32 lib will already available and we just required to link it. So MSVS 2017 and 2015 Update 1 is fine.
There was a problem hiding this comment.
We can remove this part if we are not using WIN32. Moreover we can use below instruction to compile in windows.
https://github.com/bitshares/bitshares-core/wiki/BUILD_WIN32#windows-development-environment-setup-and-build-instructions
srpatel19590
force-pushed
the
feature/GRPH-3
branch
from
b5ec44f to
b16f4e6
Compare
bobinson
changed the title
|
As we merged #98 which similar i think this pull should be closed and open a new one for the test cases we left out of we need them. |
bobinson
left a comment
bobinson
left a comment
There was a problem hiding this comment.
Please create a fresh PR with the tests.
srpatel19590
force-pushed
the
feature/GRPH-3
branch
from
217db8c to
811738f
Compare
|
@bobinson @oxarbitrage PR is updated with just additional cli tests and its fixes |
|
send a clean PR after addressing the dependencies. |
3 participants
Incorporated cli tests from bitshares and related bug fixes and/or enhancements. It requires to add #99 to run
chain_test