Skip to content

UpdateSdkMan recipe to support newJavaVersion=latest.patch #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 4 commits into from
Feb 19, 2026
Merged

UpdateSdkMan recipe to support newJavaVersion=latest.patch #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9905a9
newJavaVersion=minor
greg-at-moderne Feb 19, 2026
b85cbc3
sameMajor
greg-at-moderne Feb 19, 2026
fb44915
Use latest.patch
timtebeek Feb 19, 2026
07337a9
Option doc
greg-at-moderne Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/org/openrewrite/java/migrate/UpdateSdkMan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
public class UpdateSdkMan extends Recipe {

@Option(displayName = "Java version",
description = "The Java version to update to.",
description = "The Java version to update to. Use `latest.patch` to upgrade to the latest version within the current major version.",
required = false,
example = "17")
@Nullable
Expand Down Expand Up @@ -85,7 +85,14 @@ public Tree visit(@Nullable Tree tree, ExecutionContext ctx) {
Pattern pattern = Pattern.compile("java=(.*?)([.a-z]*-.*)");
Matcher matcher = pattern.matcher(plainText.getText());
if (matcher.find()) {
String ver = newVersion == null ? matcher.group(1) : newVersion;
String ver;
if ("latest.patch".equalsIgnoreCase(newVersion)) {
ver = matcher.group(1).split("\\.")[0];
} else if (newVersion == null) {
ver = matcher.group(1);
} else {
ver = newVersion;
}
String dist = newDistribution == null ? matcher.group(2) : "-" + newDistribution;
String newBasis = ver + dist;
Pattern majorPattern = Pattern.compile("^" + ver + "[.-].*");
Expand Down
52 changes: 52 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/UpdateSdkManTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,58 @@ void upgradeIfNewVersionIsStillSameVersionBasisAndDifferentDistribution() {
);
}

@Test
void minorUpgradesWithinSameMajorVersion() {
rewriteRun(
spec -> spec.recipe(new UpdateSdkMan("latest.patch", null)),
text(
"""
java=21.0.6-zulu
""",
spec -> spec.path(".sdkmanrc")
.after(str -> assertThat(str)
.startsWith("java=21.0.")
.doesNotContain("21.0.6")
.endsWith("-zulu")
.actual())
)
);
}

@Test
void minorUpgradeWithNewDistribution() {
rewriteRun(
spec -> spec.recipe(new UpdateSdkMan("latest.patch", "amzn")),
text(
"""
java=21.0.6-zulu
""",
spec -> spec.path(".sdkmanrc")
.after(str -> assertThat(str)
.startsWith("java=21.0.")
.endsWith("-amzn")
.actual())
)
);
}

@Test
void minorDoesNotCrossMajorVersion() {
rewriteRun(
spec -> spec.recipe(new UpdateSdkMan("latest.patch", null)),
text(
"""
java=11.0.25-tem
""",
spec -> spec.path(".sdkmanrc")
.after(str -> assertThat(str)
.startsWith("java=11.0.")
.endsWith("-tem")
.actual())
)
);
}

@Test
void doNotDowngradeVersionIfAlreadyHighEnoughSameDistribution() {
rewriteRun(
Expand Down
Loading