UpdateSdkMan recipe to support newJavaVersion=latest.patch#990
Merged
UpdateSdkMan recipe to support newJavaVersion=latest.patch#990
UpdateSdkMan recipe to support newJavaVersion=latest.patch#990Conversation
greg-at-moderne
changed the title
UpdateSdkMan recipe to support newJavaVersion=minorUpdateSdkMan recipe to support newJavaVersion=sameMajor
timtebeek
reviewed
Feb 19, 2026
timtebeek
reviewed
Feb 19, 2026
src/test/java/org/openrewrite/java/migrate/UpdateSdkManTest.java
Outdated
Show resolved
Hide resolved
Member
|
Had you considered |
Contributor
Author
|
Good idea. I like your suggestion. |
greg-at-moderne
changed the title
UpdateSdkMan recipe to support newJavaVersion=sameMajorUpdateSdkMan recipe to support newJavaVersion=latest.patch
timtebeek
approved these changes
Feb 19, 2026
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the actual proposed interface to the recipe. Is specifying
sameMajorString tonewJavaVersionoption a decent way of handling this? My hunch is it's not, but not sure what's the better way.What's changed?
Make
UpdateSdkManrecipe supportsameMajoras a possible value tonewJavaVersionoption.If specified, it will update Java within the same major version, using the same distribution (unless specified otherwise).
What's your motivation?
Have a way to quickly update all the sdkmanrc files to use unified versions. And using latest version within the same major seems to make sense.