Merged
Conversation
stmitt
approved these changes
Mar 13, 2026
🖼️ Image Diff Test FailureThe image comparison tests failed. Rendered images don't match the expected golden images. Investigate:
To approve the changes:
Last updated: Run #650 |
matzf
added a commit
that referenced
this pull request
Mar 19, 2026
Behaviour changed slightly in #919. Explicitly opt out by setting min/maxzoom to keep old simplification behaviour, to keep pixel identical test results.
matzf
added a commit
that referenced
this pull request
Mar 19, 2026
Always accept explicitly configured min/maxzoom value for geojson sources. As optimization, keep point-only sources on a single zoom level (either minzoom or maxzoom), unless minZoom and maxZoom are both explicitly configured. If no min/maxzoom are configured, the point-only tile is created at level 0. Effectively, this reverts #919.
matzf
added a commit
that referenced
this pull request
Mar 19, 2026
Always accept explicitly configured min/maxzoom value for geojson sources. As optimization, keep point-only sources on a single zoom level (either minzoom or maxzoom), unless minZoom and maxZoom are both explicitly configured. If no min/maxzoom are configured, the point-only tile is created at level 0. Effectively, this reverts #919.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By @Fabutech