Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a62f6844b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } else if (config.maxZoom.has_value()) { | ||
| options.minZoom = *config.maxZoom; | ||
| options.maxZoom = *config.maxZoom; |
There was a problem hiding this comment.
For point-only GeoJSON sources that specify only maxzoom, getEffectiveOptions() now forces both minZoom and maxZoom to that value. Tiled2dMapVectorGeoJSONLayerConfig::getZoomLevelInfos() therefore advertises only that one zoom level, and the default Tiled2dMapSource::onVisibleBoundsChanged() path drops the source at lower camera zooms because underzoom is disabled when the first available zoom identifier is not 0. A style like {"type":"geojson","maxzoom":25,...} used to render across z0..25; after this change it will stay invisible until the camera reaches z25.
Useful? React with 👍 / 👎.
shared/src/map/layers/tiled/vector/geojson/geojsonvt/geojsonvt.hpp
Outdated
Show resolved
Hide resolved
Always accept explicitly configured min/maxzoom value for geojson sources. As optimization, keep point-only sources on a single zoom level (either minzoom or maxzoom), unless minZoom and maxZoom are both explicitly configured. If no min/maxzoom are configured, the point-only tile is created at level 0. Effectively, this reverts #919.
matzf
force-pushed
the
feature/geojson-source-minmaxzoom
branch
from
8a62f68 to
ce9c54a
Compare
|
FWIW, benchmark comparison failure is expected; tests on main branch are failing (that's why this PR exists!). |
1 participant
Always accept explicitly configured min/maxzoom value for geojson sources. As optimization, keep point-only sources on a single zoom level (either minzoom or maxzoom), unless minZoom and maxZoom are both explicitly configured.
If no min/maxzoom are configured, the point-only tile is created at level 0. Effectively, this reverts #919.