Skip to content

Fix/review user optional #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
on0t0le merged 7 commits into from
May 3, 2026
Merged

Fix/review user optional #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b84275
fix(enrichment): handle null review user and team-only review requests
abuhrovyi May 2, 2026
d4906a1
docs(build): fix archive command, remove unnecessary exportArchive step
abuhrovyi May 2, 2026
15d00fc
ci: add PR template and auto-assign workflow for on0t0le
abuhrovyi May 2, 2026
1a4eb03
ci: replace auto-assign workflow with CODEOWNERS
abuhrovyi May 2, 2026
e6caf95
ci: remove PR template, let GitHub auto-fill from commits
abuhrovyi May 2, 2026
005fb60
ci: auto-populate PR body with commit list on open/sync
abuhrovyi May 2, 2026
496d61f
removed pr workflow
abuhrovyi May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @on0t0le
11 changes: 6 additions & 5 deletions GitHubWidget/Services/GitHubService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ actor GitHubService: GitHubServiceProtocol {

private struct PRReview: Decodable {
let state: String
let user: GitHubUser
let user: GitHubUser?
}

private struct CheckRunsResponse: Decodable {
Expand All @@ -97,7 +97,7 @@ actor GitHubService: GitHubServiceProtocol {
let detail = try? JSONDecoder().decode(PRDetail.self, from: data) else {
return false
}
return !detail.requestedReviewers.isEmpty
return !detail.requestedReviewers.isEmpty || !detail.requestedTeams.isEmpty
}

func fetchEnrichments(prs: [PullRequest], token: String) async -> [Int: PREnrichment] {
Expand Down Expand Up @@ -128,10 +128,11 @@ actor GitHubService: GitHubServiceProtocol {

var latestByUser: [String: String] = [:]
for review in reviews {
guard let login = review.user?.login else { continue }
if review.state != "COMMENTED" {
latestByUser[review.user.login] = review.state
} else if latestByUser[review.user.login] == nil {
latestByUser[review.user.login] = review.state
latestByUser[login] = review.state
} else if latestByUser[login] == nil {
latestByUser[login] = review.state
}
}
let approved = latestByUser.values.filter { $0 == "APPROVED" }.count
Expand Down
34 changes: 7 additions & 27 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,40 +62,20 @@ xcodebuild archive \
-archivePath build/GitHubWidget.xcarchive \
ARCHS=arm64 \
ONLY_ACTIVE_ARCH=NO \
CODE_SIGN_IDENTITY="-"
CODE_SIGN_IDENTITY="-" \
SKIP_INSTALL=NO \
INSTALL_PATH=/Applications
```

`CODE_SIGN_IDENTITY="-"` signs ad-hoc (no Apple Developer account needed). For notarization, replace with your Developer ID identity.

### 3. Export the .app
`SKIP_INSTALL=NO` + `INSTALL_PATH=/Applications` are already set in `project.yml` — these flags are shown for clarity and can be omitted.

```bash
xcodebuild -exportArchive \
-archivePath build/GitHubWidget.xcarchive \
-exportPath build/export \
-exportOptionsPlist ExportOptions.plist
```

Create `ExportOptions.plist` in the repo root:

```xml
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>method</key>
<string>mac-application</string>
<key>destination</key>
<string>export</string>
</dict>
</plist>
```

### 4. Package with pkgbuild
### 3. Package with pkgbuild

```bash
mkdir -p build/pkg-root/Applications
ditto build/export/GitHubWidget.app build/pkg-root/Applications/GitHubWidget.app
ditto build/GitHubWidget.xcarchive/Products/Applications/GitHubWidget.app build/pkg-root/Applications/GitHubWidget.app

pkgbuild \
--root build/pkg-root \
Expand All @@ -107,7 +87,7 @@ pkgbuild \

The `.pkg` installs `GitHubWidget.app` to `/Applications`.

### 5. (Optional) Sign and notarize
### 4. (Optional) Sign and notarize

Sign the package with a Developer ID Installer certificate:

Expand Down
2 changes: 2 additions & 0 deletions project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ targets:
ASSETCATALOG_COMPILER_APPICON_NAME: AppIcon
MARKETING_VERSION: "1.1.1"
CURRENT_PROJECT_VERSION: "1"
SKIP_INSTALL: NO
INSTALL_PATH: /Applications
info:
path: GitHubWidget/Info.plist
properties:
Expand Down