Fix/review user optional#11
Merged
Merged
Conversation
PRReview.user is now optional — a single malformed review (deleted account, bot, null user) no longer silently drops the entire reviews array via failed JSON decode, causing approved count to show 0. hasReviewRequests now checks requestedTeams in addition to requestedReviewers so PRs assigned only to teams are not misclassified.
Add SKIP_INSTALL=NO and INSTALL_PATH=/Applications to project.yml so the app lands in Products/Applications inside the archive. Update README to reflect the flags, drop the redundant -exportArchive step, and point ditto directly at the archive Products path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes