Skip to content

fix(email): collapse excessive blank lines in HTML-to-text conversion #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qasim-nylas merged 1 commit into from
Feb 3, 2026
Merged

fix(email): collapse excessive blank lines in HTML-to-text conversion #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions internal/cli/common/html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ func StripHTML(s string) string {
s = RemoveTagWithContent(s, "head")

// Replace block-level elements with newlines before stripping tags
// Note: table cell elements (table, td, th, tbody, thead, tfoot) are NOT included
// because they're typically used for layout; tr is included to separate rows
blockTags := []string{"br", "p", "div", "tr", "li", "h1", "h2", "h3", "h4", "h5", "h6"}
for _, tag := range blockTags {
// Handle <br>, <br/>, <br />
Expand Down Expand Up @@ -52,17 +54,25 @@ func StripHTML(s string) string {
text = strings.ReplaceAll(text, " ", " ")
}

// Collapse multiple newlines
for strings.Contains(text, "\n\n\n") {
text = strings.ReplaceAll(text, "\n\n\n", "\n\n")
}

// Trim spaces from each line
// Trim spaces from each line first
lines := strings.Split(text, "\n")
for i, line := range lines {
lines[i] = strings.TrimSpace(line)
}
text = strings.Join(lines, "\n")

// Remove consecutive empty lines, keeping at most one blank line
var cleanedLines []string
prevEmpty := false
for _, line := range lines {
isEmpty := line == ""
if isEmpty && prevEmpty {
continue // Skip consecutive empty lines
}
cleanedLines = append(cleanedLines, line)
prevEmpty = isEmpty
}

text = strings.Join(cleanedLines, "\n")

// Remove leading/trailing empty lines
return strings.TrimSpace(text)
Expand Down