fix(email): collapse excessive blank lines in HTML-to-text conversion#16
Merged
qasim-nylas merged 1 commit intonylas:mainfrom Feb 3, 2026
Merged
Conversation
Improve StripHTML function to handle table-heavy HTML emails (common in marketing emails) by collapsing consecutive empty lines to a single blank line. This prevents excessive whitespace in email display while preserving readability with paragraph separation.
qasim-nylas
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes excessive blank lines in HTML-to-text email conversion, particularly for table-heavy marketing emails (Yahoo, Azure, ChatGPT newsletters, etc.).
Problem: The
StripHTMLfunction was creating many consecutive blank lines when processing HTML emails that use nested tables for layout. Each</tr>tag added a newline, and the cleanup only collapsed 3+ newlines to 2, leaving many double-newlines.Solution:
Before
After
Changes
internal/cli/common/html.go: ImprovedStripHTMLfunction to collapse consecutive empty lines after trimmingTest Plan
TestStripHTMLtests pass (22 test cases)make cipasses (fmt, vet, lint, unit tests, security scan, vuln check)Email Types Verified