Merged
Conversation
When contributors open PRs from forks, CI fails because rebar.config.script hardcodes novaframework/nova.git as the repo URL. Add nova_repo workflow input and NOVA_REPO env var so the calling workflow can pass the fork's repo URL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nova_repoinput to therun_nra.ymlworkflow (defaults tonovaframework/novafor backwards compatibility)NOVA_REPOenv var from the new inputrebar.config.scriptto build the git URL fromNOVA_REPOenv var instead of hardcodingnovaframework/nova.gitContext
When contributors open PRs from forks, CI fails because
rebar.config.scripthardcodeshttps://github.com/novaframework/nova.git. The branch exists on the fork, not upstream. This change lets the calling workflow pass the correct repo.Test plan
novaframework/novapreserves current behavior)novaframework/novawill pass fork repo URL — fork PRs should then work🤖 Generated with Claude Code