fix: pass fork repo URL to nova_request_app CI#363
Merged
Conversation
Add nova_csrf_plugin using the synchronizer token pattern — generates a random token per session, stores it server-side, and validates it on state-changing requests (POST/PUT/PATCH/DELETE). Also fixes a session limitation where nova_session couldn't read the session ID on the very first request because nova_stream_h only set it as a response cookie. Now the session ID is also injected into the Req map so it's immediately available to the plugin pipeline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- nova_basic_handler_test: 8 tests for maybe_inject_csrf_token/2 (proplist, map, empty, no token in req) - nova_session_test: 6 tests for nova_session_id Req map fallback (get/set via Req key, cookie fallback, priority over cookie, error when no session) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When contributors open PRs from forks, nova_request_app CI fails because it only receives the branch name, not the fork repo. Pass the full repo name so nova_request_app can fetch from the correct fork. Depends on novaframework/nova_request_app accepting nova_repo input. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repo(fork's full name) alongsidebranchto therun_nraworkflowrepoasnova_repotonova_request_app's workflowgithub.event.pull_request.head.repo.full_namefor fork PRs, falls back togithub.repositoryfor direct branchesContext
When contributors open PRs from forks,
nova_request_appCI fails because it only receives the branch name and tries to fetch fromnovaframework/nova.gitwhere the branch doesn't exist. This passes the fork repo sonova_request_appcan fetch from the right place.Depends on: novaframework/nova_request_app#6 being merged first (adds
nova_repoinput).Test plan
novaframework/nova)nova_request_appCI after companion PR is merged🤖 Generated with Claude Code