Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/rules/line-length.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,14 @@ export default {
let failed = false
for (let i = 0; i < parsed.body.length; i++) {
const line = parsed.body[i]

// Skip quoted lines, e.g. for original commit messages of V8 backports.
if (line.startsWith(' ')) { continue }
// Skip lines with URLs.
if (/https?:\/\//.test(line)) { continue }
// Skip co-authorship.
if (/^co-authored-by:/i.test(line)) { continue }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure it's worth doing, but we could have a shared util to avoid duplicating the regex

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I think if we need it in a third place, then it's worth having a shared util.


if (line.length > len) {
failed = true
context.report({
Expand Down
55 changes: 55 additions & 0 deletions test/rules/line-length.js
Original file line number Diff line number Diff line change
Expand Up @@ -129,5 +129,60 @@ https://${'very-'.repeat(80)}-long-url.org/
tt.end()
})

t.test('Co-author lines', (tt) => {
const sha = 'f1496de5a7d5474e39eafaafe6f79befe5883a5b'
const author = {
name: 'Jacob Smith',
email: '3012099+JakobJingleheimer@users.noreply.github.com',
date: '2025-12-22T09:40:42Z'
}

const v = new Validator()
const overlongMessage = `fixup!: apply case-insensitive suggestion
Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>`
Comment on lines +141 to +142
Copy link
Contributor

@aduh95 aduh95 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const overlongMessage = `fixup!: apply case-insensitive suggestion
Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>`
const overlongMessage = [
'fixup!: apply case-insensitive suggestion',
'Co-authored-by Michaël Zasso <37011812+targos@users.noreply.github.com>'
].join('\n')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test-case is asserting it correctly errors. Your proposed change would cause it to not error (and then it's the same case as the other one added in this PR).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would it not error? Mind the lack of :, it should error

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (lack of) leading spaces

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how relevant are the leading spaces for the code you're adding, it feels much more likely to me that someone would forgot to add / remove by mistake the colon rather than add leading spaces. Anyway, I'm just trying to suggest something to help you get a green CI, feel free to fix the test another way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You requested this test-case though. If you don't want it, I'll just remove it and CI will be green.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I did, removing it sounds good to me

const bad = new Commit({
sha,
author,
message: overlongMessage
}, v)

bad.report = (opts) => {
tt.pass('called report')
tt.equal(opts.id, 'line-length', 'id')
tt.equal(opts.string, overlongMessage.split('\n')[1], 'string')
tt.equal(opts.level, 'fail', 'level')
}

Rule.validate(bad, {
options: {
length: 72
}
})

const good = new Commit({
sha,
author,
message: [
'fixup!: apply case-insensitive suggestion',
'Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>'
].join('\n')
}, v)

good.report = (opts) => {
tt.pass('called report')
tt.equal(opts.id, 'line-length', 'id')
tt.equal(opts.string, '', 'string')
tt.equal(opts.level, 'pass', 'level')
}

Rule.validate(good, {
options: {
length: 72
}
})

tt.end()
})

t.end()
})
Loading