feat: support co-authorship lines in body #130

JakobJingleheimer · 2025-12-09T21:23:36Z

Co-authorship lines contain an email address which is very likely longer than 72 characters (any github-anonymised email address), which cannot be broken across multiple lines.

JakobJingleheimer · 2025-12-09T21:25:38Z

@targos strangely, I can't tag people for review O.o

cc @joyeecheung

aduh95 · 2025-12-22T09:21:24Z

lib/rules/line-length.js

      // Skip lines with URLs.
      if (/https?:\/\//.test(line)) { continue }
+      // Skip co-authorship.
+      if (line.startsWith('Co-Authored-By')) { continue }


I think it would be more useful to properly validate the format (i.e. flag Co-authored-by: Author Name But No Email, etc.)

Also, could you add tests?

Email is what causes the issue though

lib/rules/line-length.js

Co-authored-by: Michaël Zasso <targos@protonmail.com>

per existing `co-authored-by-is-trailer` rule's regex

lib/rules/line-length.js

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 · 2026-01-02T22:50:01Z

test/rules/line-length.js

+      message: `
+        fixup!: apply case-insensitive suggestion
+        Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>
+      `


This is not a good test, it passes without your patch because of the leading spaces

Suggested change

message: `

fixup!: apply case-insensitive suggestion

Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>

`

message: [

'fixup!: apply case-insensitive suggestion',

'Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>',

].join('\n')

It should fail though, no?

A good regression test fails without the patch, and passes with it. Currently the test passes with and without your patch. If we want a good regression test (we do), we want one that fails without the patch.

No, I mean it seems suspicious that it isn't failing, which would suggest the implementation is bugged.

I discovered why the test is suspiciously passing:

core-validate-commit/lib/rules/line-length.js

Lines 32 to 33 in 39b93a3

// Skip quoted lines, e.g. for original commit messages of V8 backports.

if (line.startsWith(' ')) { continue }

(@aduh95 I don't know what to do about it)

aduh95 · 2026-01-02T22:51:23Z

lib/rules/line-length.js

      // Skip lines with URLs.
      if (/https?:\/\//.test(line)) { continue }
+      // Skip co-authorship.
+      if (/^co-authored-by:/i.test(line)) { continue }


nit: I'm not sure it's worth doing, but we could have a shared util to avoid duplicating the regex

🤔 I think if we need it in a third place, then it's worth having a shared util.

aduh95 · 2026-01-13T23:37:14Z

test/rules/line-length.js

+    const overlongMessage = `fixup!: apply case-insensitive suggestion
+      Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>`


Suggested change

const overlongMessage = `fixup!: apply case-insensitive suggestion

Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>`

const overlongMessage = [

'fixup!: apply case-insensitive suggestion',

'Co-authored-by Michaël Zasso <37011812+targos@users.noreply.github.com>'

].join('\n')

This test-case is asserting it correctly errors. Your proposed change would cause it to not error (and then it's the same case as the other one added in this PR).

Why would it not error? Mind the lack of :, it should error

The (lack of) leading spaces

I don't understand how relevant are the leading spaces for the code you're adding, it feels much more likely to me that someone would forgot to add / remove by mistake the colon rather than add leading spaces. Anyway, I'm just trying to suggest something to help you get a green CI, feel free to fix the test another way

You requested this test-case though. If you don't want it, I'll just remove it and CI will be green.

I don't think I did, removing it sounds good to me

feat: support co-authorship lines in body

37e4e88

JakobJingleheimer mentioned this pull request Dec 11, 2025

test_runner: support expecting a test-case to fail nodejs/node#60669

Open

aduh95 reviewed Dec 22, 2025

View reviewed changes

targos reviewed Dec 22, 2025

View reviewed changes

lib/rules/line-length.js Outdated Show resolved Hide resolved

JakobJingleheimer and others added 4 commits December 22, 2025 10:40

fixup!: apply case-insensitive suggestion

f1496de

Co-authored-by: Michaël Zasso <targos@protonmail.com>

fixup!: account for optional leading whitespace

f778e67

per existing `co-authored-by-is-trailer` rule's regex

test: add case for long co-author line

5004df9

fixup!: de-lint

d7c76aa

JakobJingleheimer requested review from aduh95 and targos December 22, 2025 12:41

aduh95 reviewed Dec 22, 2025

View reviewed changes

lib/rules/line-length.js Outdated Show resolved Hide resolved

aduh95 mentioned this pull request Dec 29, 2025

fix(co-authored-by-is-trailer): trailers do not have leading spaces #136

Merged

fixup!: align co-author regex to newly corrected pattern

dc6b810

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 reviewed Jan 2, 2026

View reviewed changes

This comment was marked as off-topic.

Sign in to view

JakobJingleheimer force-pushed the feat/support-coauthorship branch 2 times, most recently from 73cd024 to 8016e6a Compare January 12, 2026 19:36

fixup!: add contrapositive test-case

f05715d

JakobJingleheimer force-pushed the feat/support-coauthorship branch from 8016e6a to f05715d Compare January 12, 2026 19:39

eff this linter

69779f0

aduh95 reviewed Jan 13, 2026

View reviewed changes

-      message: `
-        fixup!: apply case-insensitive suggestion
-        Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>
-      `
+      message: [
+        'fixup!: apply case-insensitive suggestion',
+        'Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>',
+      ].join('\n')

	// Skip quoted lines, e.g. for original commit messages of V8 backports.
	if (line.startsWith(' ')) { continue }

		const overlongMessage = `fixup!: apply case-insensitive suggestion
		Co-authored-by: Michaël Zasso <37011812+targos@users.noreply.github.com>`

Uh oh!

feat: support co-authorship lines in body #130

Are you sure you want to change the base?

feat: support co-authorship lines in body #130

Conversation

JakobJingleheimer commented Dec 9, 2025

Uh oh!

JakobJingleheimer commented Dec 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aduh95 Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JakobJingleheimer Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

aduh95 Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aduh95 Jan 2, 2026 •

edited

Loading

JakobJingleheimer Jan 12, 2026 •

edited

Loading

aduh95 Jan 13, 2026 •

edited

Loading