Containerized pre-commit hooks#27
Open
Joonalai wants to merge 2 commits into
Open
Conversation
Joonalai
changed the title
1 task
Joonalai
force-pushed
the
containerized-pre-commit-hooks
branch
from
ad6c24c to
66cea12
Compare
Joonalai
force-pushed
the
containerized-pre-commit-hooks
branch
from
66cea12 to
078d148
Compare
komima
reviewed
Apr 1, 2026
| password: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Build and push image | ||
| uses: docker/build-push-action@v6 |
Collaborator
There was a problem hiding this comment.
Doesn't this do the same thing as above separate manual build?
| context: . | ||
| file: ./Containerfile | ||
| push: true | ||
| tags: latest # TODO: use tag |
Collaborator
There was a problem hiding this comment.
The tag here should be probably the full image image name spec incl. "tag" ie. the part after : in the name?
So ghcr.io/etc/something/here:vX.Y.Z for this build?
| on: | ||
| push: | ||
| tags: | ||
| - v* |
Collaborator
There was a problem hiding this comment.
Do we have any non-v prefixed tags? Or if we do, maybe those should be built to tagged images as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Checklist: