Fix translations in QGIS plugin#14
Merged
Merged
Conversation
vaahtokarkki
approved these changes
Mar 18, 2026
| - uses: actions/checkout@v6 | ||
| - uses: j178/prek-action@v1 | ||
| with: | ||
| extra-args: --all-files --skip update-translations |
Collaborator
There was a problem hiding this comment.
Should the transup be run with --check-changes in ci to check that translations are up to date while skipping the line number chnages?
Collaborator
Author
There was a problem hiding this comment.
Unfortunately we cannot run this hook in CI without having a image with qt binaries installed. After nlsfi/qgis-plugin-dev-tools#27 it should be possible, so maybe we could make another PR after that one is merged?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes translations in QGIS plugin and adds a pre-commit hook to update translations automatically.