Consolidate _enemies_node creation in combat_room.gd#264
Conversation
Extracts the creation and configuration of the 'Enemies' YSort node into a private helper method `_create_enemies_node()`. This fixes a DRY violation where the same node structure was created in both `_on_room_entered()` and `_spawn_enemies()`. Ensures `y_sort_enabled` is set consistently on the enemies container to maintain correct visual depth sorting. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Consolidated the creation of the
_enemies_nodeinscripts/core/combat_room.gdinto a single helper method_create_enemies_node(). This addresses the DRY violation identified in the issue and ensures that the node is always correctly configured withy_sort_enabled = true. Verified with existing unit tests for room loading and enemy spawning.Fixes #251
PR created automatically by Jules for task 18431449739130651529 started by @niyazmft