Refactor CombatRoom to use public RunManager getter#263
Conversation
… data Renamed `_get_current_room_data()` to `get_current_room_data()` in `_RunManager` and updated `CombatRoom` to use the public getter. This prevents cross-module access of private methods and ensures better maintainability. - Modified `scripts/state_machine/run_manager.gd`: renamed method and updated internal call. - Modified `scripts/core/combat_room.gd`: updated external call site. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This change refactors the way
CombatRoomaccesses current room data from_RunManager. By promoting the private_get_current_room_data()method to a publicget_current_room_data(), we adhere to GDScript encapsulation conventions and prevent potential silent breakage if_RunManager's internal structure changes. All relevant unit tests passed.Fixes #250
PR created automatically by Jules for task 10624929350021773786 started by @niyazmft