Skip to content

chore(combat_room): calls private method _get_current_room_data() on _RunManager #250

@niyazmft

Description

@niyazmft

Summary

scripts/core/combat_room.gd:34 calls _RunManager._get_current_room_data() — invoking a private method (underscore-prefixed) on another autoload from a different module. This breaks encapsulation; if _RunManager changes its internal room lookup, combat_room.gd breaks silently.

Location

scripts/core/combat_room.gd:34

Suggested Fix

  • Add a public getter get_current_room_data() -> Dictionary on _RunManager
  • Update combat_room.gd to call the public getter

Priority: P2 · Size: XS · Status: Ready

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestjulesGating label for Google Jules offload

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions