Fix Godot crash at shutdown due to dangling signal callbacks#261
Merged
niyazmft merged 3 commits intoJun 8, 2026
Merged
Conversation
Godot was crashing with EXC_BAD_ACCESS during headless shutdown because several scripts connected to Autoload singleton signals or global node signals (like Viewport or SceneTree root) but never disconnected them. This led to use-after-free errors when the engine attempted to call back into partially or fully destroyed script instances during singleton teardown. Changes: - Added `_exit_tree()` overrides to 22 scripts to explicitly disconnect from Autoloads (EventBus, EntityLifecycle, BurdenManager, etc.) and globals (SafeZoneManager, InputRouter, Viewport). - Implemented `is_connected()` checks in `_exit_tree()` to ensure robust disconnection logic. - Converted anonymous lambda connections to named methods in `VersionLabel` to facilitate reliable disconnection. - Verified clean shutdown with exit code 0 via `godot --headless --quit`. This fix unblocks CI pipelines and headless test suite execution. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Godot was crashing with EXC_BAD_ACCESS during headless shutdown because several scripts connected to Autoload singleton signals or global node signals (like Viewport or SceneTree root) but never disconnected them. This led to use-after-free errors when the engine attempted to call back into partially or fully destroyed script instances during singleton teardown. Changes: - Added `_exit_tree()` overrides to 22 scripts to explicitly disconnect from Autoloads (EventBus, EntityLifecycle, BurdenManager, etc.) and globals (SafeZoneManager, InputRouter, Viewport). - Implemented `is_connected()` checks in `_exit_tree()` to ensure robust disconnection logic. - Converted anonymous lambda connections to named methods in `VersionLabel` to facilitate reliable disconnection. - Fixed GDScript formatting issues in `scripts/ui/remap_panel.gd` and `scripts/autoload/burden_shader_manager.gd` to satisfy CI checks. - Verified clean shutdown with exit code 0 via `godot --headless --quit`. This fix unblocks CI pipelines and headless test suite execution. Co-authored-by: niyazmft <9331133+niyazmft@users.noreply.github.com>
niyazmft
deleted the
fix-shutdown-crash-dangling-signals-9964384375986748755
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a critical shutdown crash in Godot caused by dangling signal callbacks. Added
_exit_tree()methods to disconnect signals from Autoloads and global nodes in 22 identified scripts across the codebase. Verified the fix by ensuring clean exit (code 0) in headless mode.Fixes #244
PR created automatically by Jules for task 9964384375986748755 started by @niyazmft