bug(Godot): crash at shutdown due to dangling signal callback (TurnManager)

[niyazmft]

Summary

Godot crashes with EXC_BAD_ACCESS (SIGABRT) during headless shutdown (Main::cleanup). The crash stack shows GDScriptInstance::~GDScriptInstance() → Object::_predelete() → Variant::_clear_internal() with a dangling recursive_mutex at 0x1d8. This is a use-after-free on a GDScriptInstance during singleton teardown.

Root Cause

scripts/combat/turn_manager.gd:29-32 connects to EntityLifecycle.entity_state_changed in _ready() but never disconnects in _exit_tree(). Since EntityLifecycle is an autoload singleton, when Godot cleans up at shutdown, the order of singleton destruction can leave TurnManagers signal callback pointing to freed memory.

Impact

• CI pipeline always crashes (blocking all workflows)
• Headless test suite cannot complete
• Any gameplay session that exits back to menu will also crash

Location

scripts/combat/turn_manager.gd — missing _exit_tree() override

Suggested Fix

Add an _exit_tree() method in turn_manager.gd that disconnects EntityLifecycle.entity_state_changed if connected. Audit all other autoload signal connections in the project for the same pattern.

Priority: P0 · Size: S · Status: Ready

[niyazmft]

Confirmed by crash report (2026-06-08): The CI crash during Godot headless shutdown shows GDScriptInstance::~GDScriptInstance() → dangling recursive_mutex at 0x1d8 in Main::cleanup. This matches the signal lifecycle leak: TurnManager connects to EntityLifecycle.entity_state_changed in _ready() (line 34) with no _exit_tree() disconnect. During headless shutdown, singleton destruction ordering causes a use-after-free.

Fix: Add _exit_tree() in turn_manager.gd:

func _exit_tree() -> void:
    if _lifecycle and _lifecycle.is_connected("entity_state_changed", _on_entity_state_changed):
        _lifecycle.disconnect("entity_state_changed", _on_entity_state_changed)

[google-labs-jules]

Jules is on it. When finished, you will see another comment and be able to review a PR.

[google-labs-jules]

Ready for a review! A PR has been created.