Use interceptor to mock any network request#6299
Draft
tobiasKaminsky wants to merge 1 commit intomasterfrom
Draft
Use interceptor to mock any network request#6299tobiasKaminsky wants to merge 1 commit intomasterfrom
tobiasKaminsky wants to merge 1 commit intomasterfrom
Conversation
Collaborator
|
Issues
======
+ Solved 1
- Added 2
Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/ui/asynctasks/NotificationExecuteActionTask.java -1
See the complete overview on Codacy |
|
|
||
| private NotificationListAdapter.NotificationViewHolder holder; | ||
| private OwnCloudClient client; | ||
| private NextcloudClient client; |
Collaborator
There was a problem hiding this comment.
|
|
||
| private NotificationListAdapter.NotificationViewHolder holder; | ||
| private OwnCloudClient client; | ||
| private NextcloudClient client; |
Collaborator
There was a problem hiding this comment.
Collaborator
|
stable-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
Collaborator
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14491.apk |
Collaborator
|
master-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Collaborator
Collaborator
Codacy397Lint
SpotBugs (new)
SpotBugs (master)
Android-library is not set to master branch in build.gradleSpotBugs increased! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to nextcloud/android-library#454
This approach let us mock any network request when run an instrumented test (for now).
I am unsure about this concept:
What do you think?
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests