Activity mock by tobiasKaminsky · Pull Request #6301 · nextcloud/android

tobiasKaminsky · 2020-06-16T14:03:51Z

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

Tests written, or not not needed

ActivityIT first one separate annotations to keep track and easier create screenshots Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

nextcloud-android-bot · 2020-06-16T14:07:02Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 2
           

Complexity increasing per file
==============================
- src/main/java/com/nextcloud/client/di/ActivitiesModule.java  1

See the complete overview on Codacy

nextcloud-android-bot · 2020-06-16T14:07:02Z

scripts/updateScreenshotsWithoutServer.sh

+((retryCount++))
+done
+
+sed -i s'#<bool name="is_beta">true</bool>#<bool name="is_beta">false</bool>#'g src/main/res/values/setup.xml


Issue found: This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'?

nextcloud-android-bot · 2020-06-16T14:07:04Z

scripts/updateScreenshotsWithoutServer.sh

+
+scripts/wait_for_emulator.sh
+
+sed -i s'#<bool name="is_beta">false</bool>#<bool name="is_beta">true</bool>#'g src/main/res/values/setup.xml


Issue found: This word is outside of quotes. Did you intend to 'nest '"'single quotes'"' instead'?

nextcloud-android-bot · 2020-06-16T14:33:21Z

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14494.apk

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

nextcloud-android-bot · 2020-06-16T14:35:21Z

stable-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2020-06-16T14:35:38Z

master-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

nextcloud-android-bot · 2020-06-16T14:40:08Z

Codacy

397

Lint

Type	master	PR
Warnings	95	95
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	63
Internationalization Warnings	9
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	75
Security Warnings	44
Dodgy code Warnings	142
Total	373

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	63
Internationalization Warnings	9
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	75
Security Warnings	44
Dodgy code Warnings	142
Total	373

ezaquarii

If I understand it correctly, we have a specialized app to conduct screenshot tests, right?
And we want to swap network I/O layer to eliminate reliance on live server?

Swapping big compinents for tests is the right approach to do it. Ideally, we'd like to swap 1 component to achieve it, but with network ops spread between independent *Operation classes, doing it at HTTP client level seems to be a reasonable choice.

However, this will be really tedious and fragile to mock, as mock responses would have to track server changes. Of course this could be worked out as well with suitable refactoring, but the question about cost to benefit ratio must be answered first.

ezaquarii · 2020-06-16T19:24:37Z

src/androidTest/java/com/owncloud/android/LocalActivitiesRepository.java

+import static com.owncloud.android.ui.activity.ContactsPreferenceActivity.TAG;
+
+public class LocalActivitiesRepository implements ActivitiesRepository {
+    String json = "{\n" +


Kotlin allows to use """ to denote raw strings that do not need any escaping. It's really handy for stuff like that and regexps.

ezaquarii · 2020-06-16T19:27:16Z

src/main/java/com/owncloud/android/ui/adapter/ActivityListAdapter.java

        this.capability = capability;
        this.clientFactory = clientFactory;
+        try {
+            this.client = clientFactory.createNextcloudClient(currentAccountProvider.getUser());


Wouldn't that cause NPE somewhere down the line?

ezaquarii · 2020-06-16T19:30:54Z

src/main/java/com/owncloud/android/utils/ScreenshotWithServerTest.java

+
+@Retention(RetentionPolicy.RUNTIME)
+@Target(ElementType.METHOD)
+public @interface ScreenshotWithServerTest {


Why is it called with server?

ezaquarii · 2020-06-16T19:39:38Z

src/main/java/com/owncloud/android/MainApp.java

    }

+    @VisibleForTesting
+    public void setupDagger() {


We can make it protected.

tobiasKaminsky · 2020-06-17T06:18:22Z

If I understand it correctly, we have a specialized app to conduct screenshot tests, right?
And we want to swap network I/O layer to eliminate reliance on live server?

Yes.

Swapping big compinents for tests is the right approach to do it. Ideally, we'd like to swap 1 component to achieve it, but with network ops spread between independent *Operation classes, doing it at HTTP client level seems to be a reasonable choice.

I have two approaches…

This one uses dagger as mocks one specific activitiesRepository.
Then there is Use interceptor to mock any network request #6299 which tries to use one generic interceptor to mock any server request.
another approach would be to have a lightweight (and probably stateless) http server which serves static responses.

My intention was to have a reproducable state, and ideally no external components (e.g. docker) needed (this is true for option 1/2).
Another benefit is that it is currently all handled in code, so there is no context switching for testing.

tobiasKaminsky · 2020-06-17T06:22:37Z

However, this will be really tedious and fragile to mock, as mock responses would have to track server changes. Of course this could be worked out as well with suitable refactoring, but the question about cost to benefit ratio must be answered first.

True.
My "ideal" plan would look like this:

in library repo we test against stable/master
in files app we test against mocked server for most of the operations

So if there are api changes on server they would first be captured by library.

But as you said, I am really uncertain about time effort with this interceptor approach…
Maybe it is first a good start to have "only" #6301 (mocking some parts of the app for testing).

Screenshot tests without server

79151ca

ActivityIT first one separate annotations to keep track and easier create screenshots Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky added the 2. developing label Jun 16, 2020

tobiasKaminsky requested a review from ezaquarii June 16, 2020 14:03

nextcloud-android-bot reviewed Jun 16, 2020

View reviewed changes

ezaquarii reviewed Jun 16, 2020

View reviewed changes

src/main/java/com/owncloud/android/MainApp.java

}

@VisibleForTesting

public void setupDagger() {

Copy link

Collaborator

ezaquarii Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make it protected.


		scripts/wait_for_emulator.sh

		sed -i s'#<bool name="is_beta">false</bool>#<bool name="is_beta">true</bool>#'g src/main/res/values/setup.xml

Uh oh!

Conversation

tobiasKaminsky commented Jun 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

nextcloud-android-bot commented Jun 16, 2020

Uh oh!

nextcloud-android-bot Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

nextcloud-android-bot Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

nextcloud-android-bot commented Jun 16, 2020

Uh oh!

nextcloud-android-bot commented Jun 16, 2020

Uh oh!

nextcloud-android-bot commented Jun 16, 2020

Uh oh!

nextcloud-android-bot commented Jun 16, 2020

Codacy

Lint

SpotBugs (new)

SpotBugs (master)

Uh oh!

ezaquarii left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ezaquarii Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

ezaquarii Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

ezaquarii Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

ezaquarii Jun 16, 2020

Choose a reason for hiding this comment

Uh oh!

tobiasKaminsky commented Jun 17, 2020

Uh oh!

tobiasKaminsky commented Jun 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tobiasKaminsky commented Jun 16, 2020 •

edited

Loading

ezaquarii left a comment •

edited

Loading