Switch all notification to V2

[tobiasKaminsky]

Needs: nextcloud/android-library#453

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

• Tests written, or not not needed

[AlvaroBrey]

12-12 13:03:35.263  9843 10371 D GetNotificationRemoteOperation: Not yet implemented
12-12 13:03:35.264  9843 10371 E NotificationWork: Error creating account
12-12 13:03:35.264  9843 10371 E NotificationWork: java.lang.UnsupportedOperationException: Not yet implemented
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at com.owncloud.android.lib.common.operations.RemoteOperation.run(RemoteOperation.java:110)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at com.owncloud.android.lib.common.operations.RemoteOperation.execute(RemoteOperation.java:220)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at com.nextcloud.client.jobs.NotificationWork.fetchCompleteNotification(NotificationWork.kt:256)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at com.nextcloud.client.jobs.NotificationWork.doWork(NotificationWork.kt:125)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at androidx.work.Worker$1.run(Worker.java:86)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
12-12 13:03:35.264  9843 10371 E NotificationWork: 	at java.lang.Thread.run(Thread.java:1012)
12-12 13:03:35.266  9843 10119 I WM-WorkerWrapper: Worker result SUCCESS for Work [ id=00a1825a-379d-4fb2-b0d3-b87c2bbcee0a, tags={ name:notification, com.nextcloud.client.jobs.NotificationWork, timestamp:1670846615204, * }

Getting this when testing with occ notification:test-push <username>

[tobiasKaminsky]

12-12 13:03:35.263  9843 10371 D GetNotificationRemoteOperation: Not yet implemented

This should have been detected by tests in library's PR.
Let me check.

[tobiasKaminsky]

@AlvaroBrey indeed this was not covered by library tests.
Now it should work.

[AlvaroBrey]

/rebase

[tobiasKaminsky]

Manually rebased

[tobiasKaminsky]

@AlvaroBrey is this sort of a Java<->Kotlin "problem"?

[AlvaroBrey]

@AlvaroBrey is this sort of a Java<->Kotlin "problem"?

Looks like it, yeah. From a short research it looks like something that cannot be solved, so either work around (by defining it as RemoteOperationResult<List<? extends Notification>> and then casting getResultData to List<Notification>) or convert the class to Kotlin seem to be the only options.

[AlvaroBrey]

/rebase

[AlvaroBrey]

/rebase

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11140.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.