notification to v2 by tobiasKaminsky · Pull Request #453 · nextcloud/android-library

tobiasKaminsky · 2020-06-16T10:36:11Z

needs tests

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

codecov · 2020-06-16T10:49:56Z

Codecov Report

❌ Patch coverage is 68.84058% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.13%. Comparing base (2504465) to head (8e2079f).
⚠️ Report is 444 commits behind head on master.

Files with missing lines	Patch %	Lines
...notifications/CreateNotificationRemoteOperation.kt	68.96%	7 Missing and 2 partials ⚠️
...s/notifications/GetNotificationsRemoteOperation.kt	70.96%	7 Missing and 2 partials ⚠️
...fications/DeleteAllNotificationsRemoteOperation.kt	61.90%	7 Missing and 1 partial ⚠️
...notifications/DeleteNotificationRemoteOperation.kt	61.90%	7 Missing and 1 partial ⚠️
...in/java/com/nextcloud/operations/Utf8PostMethod.kt	0.00%	4 Missing ⚠️
...es/notifications/GetNotificationRemoteOperation.kt	86.20%	4 Missing ⚠️
...c/main/java/com/nextcloud/operations/PostMethod.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #453      +/-   ##
============================================
+ Coverage     48.96%   49.13%   +0.17%     
- Complexity     1013     1036      +23     
============================================
  Files           209      217       +8     
  Lines          7928     8128     +200     
  Branches       1020     1040      +20     
============================================
+ Hits           3882     3994     +112     
- Misses         3490     3567      +77     
- Partials        556      567      +11

Files with missing lines	Coverage Δ
...c/main/java/com/nextcloud/operations/PostMethod.kt	`80.00% <66.66%> (-20.00%)`	⬇️
...in/java/com/nextcloud/operations/Utf8PostMethod.kt	`0.00% <0.00%> (ø)`
...es/notifications/GetNotificationRemoteOperation.kt	`86.20% <86.20%> (ø)`
...fications/DeleteAllNotificationsRemoteOperation.kt	`61.90% <61.90%> (ø)`
...notifications/DeleteNotificationRemoteOperation.kt	`61.90% <61.90%> (ø)`
...notifications/CreateNotificationRemoteOperation.kt	`68.96% <68.96%> (ø)`
...s/notifications/GetNotificationsRemoteOperation.kt	`70.96% <70.96%> (ø)`

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

.drone.yml

...n/java/com/owncloud/android/lib/resources/notifications/GetNotificationsRemoteOperation.java

github-actions · 2022-11-25T11:27:48Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

github-actions · 2022-12-05T10:33:18Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

github-actions · 2022-12-12T14:34:23Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

AlvaroBrey · 2022-12-16T10:11:15Z

/rebase

github-actions · 2022-12-16T10:16:35Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

tobiasKaminsky · 2023-02-08T09:47:31Z

/rebase

github-actions · 2023-02-09T08:42:34Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

github-actions · 2023-02-09T08:43:17Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

github-actions · 2023-02-09T09:23:29Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	10
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	141

...main/java/com/owncloud/android/lib/resources/notifications/GetNotificationRemoteOperation.kt

...ain/java/com/owncloud/android/lib/resources/notifications/GetNotificationsRemoteOperation.kt

github-actions · 2023-02-22T14:05:16Z

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	9
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	42
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	139

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	9
Correctness Warnings	35
Internationalization Warnings	6
Malicious code vulnerability Warnings	43
Multithreaded correctness Warnings	3
Performance Warnings	12
Security Warnings	1
Dodgy code Warnings	31
Total	140