feat: VRM表示の同期とローディング体験の最適化#21
Open
naolab wants to merge 3 commits into
Open
Conversation
- AIアシスタント機能セクションを削除（ターミナルから直接起動する仕様に変更） - キャラクター設定セクションを追加（表示キャラ/読み上げキャラの設定方法） - VS Code Dark の名称を削除し「ダークテーマ」に統一 - アイコンモードの説明を「負荷軽減」目的に修正 - キャラ選択がアイコンから行える旨を追記 - CURRENT_FEATURES.md を新規作成（機能一覧の参照用） Co-authored-by: Gemini <gemini@google.com>
- fix-paths.js: RSCペイロード内の絶対パスを相対パスに修正 - config-manager.js: モネのVRMパスを public から out に変更 - main.js: app.asar.unpacked パスの解決と out へのフォールバックロジック追加 - package.json: out 内のVRMファイルを asarUnpack に追加 - character-display-manager.js: iframe取得のフォールバック追加 Co-authored-by: Gemini <gemini@google.com>
- Three.jsの初回描画とローディング非表示を同期 - レガシーな LoadingScreen.js を削除し起動を高速化 - app.js での ReferenceError を修正 Co-authored-by: Claude Code <claude@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
useThreeScene.tsに実装VRMViewer.tsxで描画完了までロード画面を維持するように同期useEffectとuseRefを使用し、キャラクター切り替え時のロード状態リセットを確実化LoadingScreen.jsを削除app.jsでのloadingScreen参照エラーを修正変更理由
動作確認
レビュー観点
useThreeScene.tsのisVrmFirstFrameRenderedRefによる描画検知ロジック