Skip to content

fix(app): improve file tree naming flow#380

Merged
murongg merged 1 commit into
mainfrom
fix/file-tree-naming-flow
Jun 22, 2026
Merged

fix(app): improve file tree naming flow#380
murongg merged 1 commit into
mainfrom
fix/file-tree-naming-flow

Conversation

@murongg

@murongg murongg commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Select only the basename when creating or renaming Markdown files from prefilled file tree inputs.
  • Finish active file tree inputs before navigating to another file or folder row.
  • Preserve empty template suggested names and show native create/rename failures as error toasts.

Why

  • File tree naming inputs should behave consistently when focus moves across the sidebar.
  • Duplicate native file names previously failed without visible feedback.

Validation

  • pnpm --filter @markra/app test -- src/App.test.tsx src/lib/templates.test.ts src/components/MarkdownFileTreeDrawer.test.tsx passed
  • pnpm --filter @markra/shared test -- src/i18n/index.test.ts passed
  • pnpm --filter @markra/app typecheck:test passed
  • pnpm --filter @markra/app build passed
  • pnpm --filter @markra/shared build passed

Related Issues

Select file basenames in create and rename inputs, finish active file tree inputs before row navigation, and surface native create/rename failures in toasts.

Closes #267
@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 22, 2026 10:26am

@murongg murongg marked this pull request as ready for review June 22, 2026 10:26
@murongg murongg merged commit b012372 into main Jun 22, 2026
4 checks passed
@murongg murongg deleted the fix/file-tree-naming-flow branch June 22, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 根据模板新建文件的命名逻辑建议

1 participant