Skip to content

fix(app): dismiss transient state across panes#381

Merged
murongg merged 1 commit into
mainfrom
fix/cross-pane-transient-dismissal
Jun 22, 2026
Merged

fix(app): dismiss transient state across panes#381
murongg merged 1 commit into
mainfrom
fix/cross-pane-transient-dismissal

Conversation

@murongg

@murongg murongg commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • Dismiss the AI selection floating toolbar when a pointer starts outside the toolbar or its heading menu.
  • Wire the app to hide that toolbar on outside clicks, including sidebars.
  • Cancel file-tree create inputs when pointer focus leaves the file tree.

Why

Validation

  • pnpm --filter @markra/app test -- src/components/AiSelectionToolbar.test.tsx -t "dismisses when a pointer starts outside the toolbar" passed
  • pnpm --filter @markra/app test -- src/components/MarkdownFileTreeDrawer.test.tsx -t "cancels create inputs when a pointer starts outside the file tree" passed
  • pnpm --filter @markra/app test -- src/components/AiSelectionToolbar.test.tsx src/components/MarkdownFileTreeDrawer.test.tsx passed on rerun
  • pnpm --filter @markra/app typecheck:test passed
  • pnpm --filter @markra/app build passed

Related Issues

Dismiss the AI selection toolbar on outside pointerdown and cancel file-tree create inputs when pointer focus leaves the file tree.

Refs #379
@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markra-web Ready Ready Preview, Comment Jun 22, 2026 10:40am

@murongg murongg marked this pull request as ready for review June 22, 2026 10:44
@murongg murongg merged commit 00b67c9 into main Jun 22, 2026
4 checks passed
@murongg murongg deleted the fix/cross-pane-transient-dismissal branch June 22, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Editor]: 浮动工具栏不能自动收起

1 participant