feat: use extern functions in dispatch table#90
Merged
Wodann merged 4 commits intomun-lang:masterfrom Jan 25, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=========================================
- Coverage 74.63% 74.33% -0.3%
=========================================
Files 117 119 +2
Lines 8893 9199 +306
=========================================
+ Hits 6637 6838 +201
- Misses 2256 2361 +105
Continue to review full report at Codecov.
|
Wodann
requested changes
Jan 24, 2020
Collaborator
Wodann
left a comment
There was a problem hiding this comment.
Nice work! A very clean and minimal implementation.
It might be good to add unit tests for all of the different types that can be input as intrinsic arguments and return types.
Wodann
approved these changes
Jan 25, 2020
This was referenced Jan 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds dynamic linking of
mallocthrough the dispatch table. The use of malloc is still hacked in the runtime but this allows us to integrate all PRs that require it.