fix: link against ucrt.lib to resolve missing symbols for malloc#82
Closed
Wodann wants to merge 1 commit intomun-lang:masterfrom
Closed
fix: link against ucrt.lib to resolve missing symbols for malloc#82Wodann wants to merge 1 commit intomun-lang:masterfrom
Wodann wants to merge 1 commit intomun-lang:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 74.63% 74.37% -0.26%
==========================================
Files 117 117
Lines 8893 8894 +1
==========================================
- Hits 6637 6615 -22
- Misses 2256 2279 +23
Continue to review full report at Codecov.
|
Wodann
force-pushed
the
fix/malloc
branch
8 times, most recently
from
12180fa to
6e52a4e
Compare
Collaborator
Author
|
No longer necessary as PR #90 introduces runtime linked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for Windows, as long as we are using
malloc.