fix(readme): correct SubQuestionQueryEngine link and fix formatting#247
Open
abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
Open
fix(readme): correct SubQuestionQueryEngine link and fix formatting#247abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
abdelhadi703 wants to merge 1 commit intomistralai:mainfrom
Conversation
…tting - SubQuestionQueryEngine.ipynb was incorrectly linking to RouterQueryEngine.ipynb instead of SubQuestionQueryEngine.ipynb - prompt_optimization.ipynb had a double closing parenthesis )) breaking the markdown link, and missing table formatting (trailing pipe) Related to mistralai#244
17 tasks
Author
|
Hi @mistralai/team, Gentle ping on this PR. It's been almost a month without feedback. This fix corrects a broken link and formatting issue in the README. Happy to address any review comments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookbook Pull Request
Description
Fixes two additional README issues related to #244 (complementary to #245):
SubQuestionQueryEngine.ipynbwrong link target: The link text saysSubQuestionQueryEngine.ipynbbut pointed tothird_party/LlamaIndex/RouterQueryEngine.ipynb. Fixed to point to the correct filethird_party/LlamaIndex/SubQuestionQueryEngine.ipynb(which exists).prompt_optimization.ipynbformatting: Double closing parenthesis))broke the markdown link syntax. Also added missing trailing pipe|to complete the table row.Type of Change
Cookbook Checklist:
README.md Checklist
Additional Context
These fixes complement PR #245 which addresses the four dead links (404) reported in issue #244. The two issues fixed here were not covered by that PR.