Skip to content

Remove dead links from Third Party Tools section#245

Open
cihandemir wants to merge 1 commit intomistralai:mainfrom
cihandemir:patch-1
Open

Remove dead links from Third Party Tools section#245
cihandemir wants to merge 1 commit intomistralai:mainfrom
cihandemir:patch-1

Conversation

@cihandemir
Copy link
Copy Markdown

Cookbook Pull Request

Description

Fixes #244

The following links were returning 404:

  • third_party/langchain/corrective_rag_mistral.ipynb
  • third_party/langchain/langgraph_crag_mistral.ipynb
  • third_party/langtrace/langtrace_mistral.ipynb
  • third_party/langchain/self_rag_mistral.ipynb

Removed them from the README as they appear to be outdated or removed.

...

Type of Change

What type of PR is it?

  • New Cookbook
    • Notebook File
      • Does it work on google colab?
    • Markdown File
  • Cookbook Update
    • Code Refactoring
    • Bug Fix
  • README.md Update

  • Other (please describe):

Cookbook Checklist:

  • My code is easy to read and well structured.
  • I've tagged the versions of any dependency required.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings or errors.

  • My changes do not concern the cookbooks.

README.md Checklist

  • I've added my cookbook to the table.

  • My changes do not concern the README file.

Additional Context

Add any other context or screenshots about the feature request here.

...

Fixes mistralai#244 

The following links were returning 404:
- third_party/langchain/corrective_rag_mistral.ipynb
- third_party/langchain/langgraph_crag_mistral.ipynb
- third_party/langtrace/langtrace_mistral.ipynb
- third_party/langchain/self_rag_mistral.ipynb

Removed them from the README as they appear to be outdated or removed.
@abdelhadi703
Copy link
Copy Markdown

Great catch on the dead links! 👍

While reviewing, I noticed two additional issues in the README that aren't covered by this PR:

  1. Wrong link target for SubQuestionQueryEngine.ipynb (line 103): The link text says SubQuestionQueryEngine.ipynb but it points to third_party/LlamaIndex/RouterQueryEngine.ipynb instead of third_party/LlamaIndex/SubQuestionQueryEngine.ipynb. The correct file does exist.

  2. Formatting issue on prompt_optimization.ipynb (line 110): There's a double closing parenthesis )) which breaks the markdown link, and the table row is missing its trailing pipe |.

I've opened a separate PR (#247) to fix these two issues, so they complement your changes here.

@cihandemir
Copy link
Copy Markdown
Author

Thanks for the feedback and for handling the additional fixes in #247, @abdelhadi703! Much appreciated. My PR should be ready to go once the workflows are cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dead links in third party tools list

2 participants