Skip to content

CI/CD - Update the NumPy/Pandas API usage #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
polarG wants to merge 7 commits into
base: hongtaozhang/fix-image-build
Choose a base branch
from
Open

CI/CD - Update the NumPy/Pandas API usage #774

polarG wants to merge 7 commits into from
+12 −8

Conversation

@polarG
Copy link
Contributor

@polarG polarG commented Jan 21, 2026 •
edited
Loading

Description

  • Deprecated API arguments, 'interpolation', when numpy >v1.22.0. And it was removed since v2.4.0.
  • Pandas to_exel() failed in unit test.

Solution

  • Update the NumPy API usage to support NumPy 1.22.0+ while maintaining backward compatibility with earlier versions.
  • Fixed the pandas to_excel() API compatibility issue. In newer versions of pandas (2.0+), the 'sheet_name' parameter must be passed as a keyword argument rather than a positional argument

Update the NumPy API usage to support NumPy 1.22.0+ while maintaining…
5dca7de 
… backward compatibility with earlier versions
@polarG polarG requested a review from a team as a code owner January 21, 2026 23:14
@polarG polarG changed the title CICD - Update the NumPy API usage to support NumPy 1.22.0+ CI/CD - Update the NumPy API usage to support NumPy 1.22.0+ Jan 21, 2026
@polarG polarG requested review from abuccts and guoshzhao January 21, 2026 23:15
@abuccts abuccts requested a review from Copilot January 21, 2026 23:25
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the NumPy API usage to support NumPy 1.22.0+ while maintaining backward compatibility with earlier versions. The change addresses the deprecation and eventual removal of the interpolation parameter in np.percentile(), which was replaced with the method parameter.

Changes:

  • Updated _process_percentile_result method to use try-except pattern for NumPy API compatibility
  • Attempts to use the newer method parameter first, falling back to deprecated interpolation parameter for older NumPy versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@polarG polarG mentioned this pull request Jan 21, 2026
Open
@codecov
Copy link

codecov bot commented Jan 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.70%. Comparing base (4d7d6c4) to head (8c5146a).
⚠️ Report is 2 commits behind head on hongtaozhang/fix-image-build.

Additional details and impacted files 
@@                      Coverage Diff                      @@
##           hongtaozhang/fix-image-build     #774   +/-   ##
=============================================================
  Coverage                         85.69%   85.70%           
=============================================================
  Files                               102      102           
  Lines                              7699     7703    +4     
=============================================================
+ Hits                               6598     6602    +4     
  Misses                             1101     1101
Flag Coverage Δ
cpu-python3.10-unit-test 70.96% <77.77%> (-0.02%) ⬇️
cpu-python3.12-unit-test 70.96% <77.77%> (-0.01%) ⬇️
cpu-python3.7-unit-test 70.43% <100.00%> (+0.01%) ⬆️
cuda-unit-test 83.59% <77.77%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

polarG and others added 2 commits January 21, 2026 15:53
@polarG
Update superbench/benchmarks/base.py
dd5eb84 
Update exception handler.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix lint issue.
348ebba
@polarG polarG changed the title CI/CD - Update the NumPy API usage to support NumPy 1.22.0+ CI/CD - Update the NumPy/Pandas API usage Jan 22, 2026
@polarG polarG requested a review from Copilot January 22, 2026 00:48
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@polarG
Update superbench/benchmarks/base.py
1b7c7b6 
Remove redundant logic.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@polarG polarG requested a review from Copilot January 22, 2026 00:54
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

polarG and others added 2 commits January 21, 2026 17:03
@polarG
Update superbench/benchmarks/base.py
abe8fa2 
Revert to previous version.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix DataFrame.drop() API usage.
8c5146a
@polarG polarG requested a review from Copilot January 22, 2026 02:17
Copilot AI reviewed Jan 22, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@abuccts abuccts abuccts approved these changes

@guoshzhao guoshzhao Awaiting requested review from guoshzhao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@polarG @abuccts