Skip to content

Conversation

@polarG
Copy link
Contributor

@polarG polarG commented Jan 6, 2026

Description

  • When building the CUDA 11.1.1 image, pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1). As a result, pip attempts to build wandb from source. However, the build fails because the image does not have Go installed, which is required for building wandb from source. Then the error appears.
  • Deprecated API arguments, 'interpolation', when numpy >v1.22.0. And it was removed since v2.4.0.

Solution

  • For the CUDA 11.1.1 build, install the required build tools (e.g., Go, Rust, and Cargo) needed for wandb.
  • Update the NumPy API usage to support NumPy 1.22.0+ while maintaining backward compatibility with earlier versions.

@polarG polarG self-assigned this Jan 6, 2026
@polarG polarG added the enhancement New feature or request label Jan 6, 2026
@polarG polarG requested a review from a team as a code owner January 6, 2026 22:55
@polarG polarG added CI/CD Continuous integration or deployment dependencies Pull requests that update a dependency file labels Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (c99380b) to head (c4213bf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   85.69%   85.69%           
=======================================
  Files         102      102           
  Lines        7699     7699           
=======================================
  Hits         6598     6598           
  Misses       1101     1101           
Flag Coverage Δ
cpu-python3.10-unit-test 70.97% <ø> (ø)
cpu-python3.7-unit-test 70.42% <ø> (ø)
cuda-unit-test 83.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@polarG polarG changed the title CI/CD - Fix Image build for cuda11.1.1 CI/CD - Fix Image build for cuda11.1.1 and update numpy API Jan 7, 2026
@polarG polarG requested review from abuccts and guoshzhao January 7, 2026 18:33
Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)

According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?

However, the build fails because the image does not have Go installed, which is required for building wandb from source.

Why not just add an apt-get install -y golang?

@polarG polarG changed the title CI/CD - Fix Image build for cuda11.1.1 and update numpy API CI/CD - Remove Image build for cuda11.1.1 and update numpy API Jan 12, 2026
@polarG polarG enabled auto-merge (squash) January 12, 2026 22:25
@polarG
Copy link
Contributor Author

polarG commented Jan 12, 2026

pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)

According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?

However, the build fails because the image does not have Go installed, which is required for building wandb from source.

Why not just add an apt-get install -y golang?

Added build-essential packages to the CUDA 11.1.1 Dockerfile to enable building wandb.

Hongtao Zhang added 6 commits January 13, 2026 18:08
This reverts commit 059daa9.

	modified:   .github/workflows/build-image.yml
	new file:   dockerfile/cuda11.1.1.dockerfile
This reverts commit 4f23173.

	modified:   dockerfile/cuda11.1.1.dockerfile
@polarG polarG changed the title CI/CD - Remove Image build for cuda11.1.1 and update numpy API CI/CD - Fix Image build for cuda11.1.1 and unit test pipelines Jan 14, 2026
@polarG polarG changed the title CI/CD - Fix Image build for cuda11.1.1 and unit test pipelines CI/CD - Fix Image build for cuda11.1.1 and py unit test pipelines Jan 14, 2026
@abuccts abuccts requested a review from Copilot January 14, 2026 23:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CI/CD issues affecting the CUDA 11.1.1 Docker image build and Python unit test pipelines by addressing two main problems: missing build dependencies for wandb installation and deprecated NumPy API usage.

Changes:

  • Added Go and Rust build tools to the CUDA 11.1.1 Dockerfile to support wandb v0.23.1 source builds
  • Updated NumPy percentile API usage to support NumPy 2.x while maintaining backward compatibility with 1.x

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
superbench/benchmarks/base.py Updated np.percentile API to use try-except for backward compatibility, preferring method='nearest' for NumPy 2.x and falling back to interpolation='nearest' for older versions
dockerfile/cuda11.1.1.dockerfile Added Go 1.24, Rust, and Cargo installations with required dependencies to enable wandb source builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@polarG
Copy link
Contributor Author

polarG commented Jan 14, 2026

pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)

According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?

However, the build fails because the image does not have Go installed, which is required for building wandb from source.

Why not just add an apt-get install -y golang?

The default go version is not enough for wandb-0.23.1.

Copilot AI review requested due to automatic review settings January 21, 2026 23:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@abuccts abuccts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the title and descriptions accordingly?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

WORKDIR ${SB_HOME}

# Install Rust for wandb build (required by megatron_lm target)
RUN curl https://sh.rustup.rs -sSf | sh -s -- -y
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing Rust via curl https://sh.rustup.rs | sh is an unverified remote script execution pattern. To reduce supply-chain risk and improve reproducibility, prefer installing rustc/cargo from apt (if available) or pin the rustup/toolchain version and verify the installer (e.g., checksum/signature) before executing it.

Copilot uses AI. Check for mistakes.
Comment on lines 53 to +58
&& \
add-apt-repository -y ppa:longsleep/golang-backports && \
apt-get update && \
apt-get install -y golang-1.24-go=1.24* && \
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the longsleep/golang-backports PPA introduces an external repository dependency that can make builds less reproducible/available over time. If possible, prefer an official Go tarball with a pinned checksum (or another pinned source) to reduce CI flakiness from PPA changes/outages.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Continuous integration or deployment dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants