-
Notifications
You must be signed in to change notification settings - Fork 83
CI/CD - Fix Image build for cuda11.1.1 and py unit test pipelines #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 102 102
Lines 7699 7699
=======================================
Hits 6598 6598
Misses 1101 1101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abuccts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip (Python 3.8) cannot find a pre-built wheel for the latest wandb release (v0.23.1)
According to wandb v0.23.1, it's compatible with py3.8. Maybe you need to upgrade pip/wheel?
However, the build fails because the image does not have Go installed, which is required for building wandb from source.
Why not just add an apt-get install -y golang?
Added build-essential packages to the CUDA 11.1.1 Dockerfile to enable building wandb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes CI/CD issues affecting the CUDA 11.1.1 Docker image build and Python unit test pipelines by addressing two main problems: missing build dependencies for wandb installation and deprecated NumPy API usage.
Changes:
- Added Go and Rust build tools to the CUDA 11.1.1 Dockerfile to support wandb v0.23.1 source builds
- Updated NumPy percentile API usage to support NumPy 2.x while maintaining backward compatibility with 1.x
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| superbench/benchmarks/base.py | Updated np.percentile API to use try-except for backward compatibility, preferring method='nearest' for NumPy 2.x and falling back to interpolation='nearest' for older versions |
| dockerfile/cuda11.1.1.dockerfile | Added Go 1.24, Rust, and Cargo installations with required dependencies to enable wandb source builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The default go version is not enough for wandb-0.23.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abuccts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the title and descriptions accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dockerfile/cuda11.1.1.dockerfile
Outdated
| WORKDIR ${SB_HOME} | ||
|
|
||
| # Install Rust for wandb build (required by megatron_lm target) | ||
| RUN curl https://sh.rustup.rs -sSf | sh -s -- -y |
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing Rust via curl https://sh.rustup.rs | sh is an unverified remote script execution pattern. To reduce supply-chain risk and improve reproducibility, prefer installing rustc/cargo from apt (if available) or pin the rustup/toolchain version and verify the installer (e.g., checksum/signature) before executing it.
| && \ | ||
| add-apt-repository -y ppa:longsleep/golang-backports && \ | ||
| apt-get update && \ | ||
| apt-get install -y golang-1.24-go=1.24* && \ |
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the longsleep/golang-backports PPA introduces an external repository dependency that can make builds less reproducible/available over time. If possible, prefer an official Go tarball with a pinned checksum (or another pinned source) to reduce CI flakiness from PPA changes/outages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Description
Solution