Skip to content

Suppress SCNetworkReachability deprecation warnings #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmehta001 wants to merge 1 commit into from
Closed

Suppress SCNetworkReachability deprecation warnings #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions third_party/Reachability/ODWReachability.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
#import <netinet/in.h>
#import <arpa/inet.h>

// The SCNetworkReachability APIs used throughout this file were deprecated
// in iOS 17.4. A full migration to NWPathMonitor is tracked separately;
// suppress the warnings for the entire file until then.
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"


NSString *const kNetworkReachabilityChangedNotification = @"NetworkReachabilityChangedNotification";

Expand Down Expand Up @@ -432,7 +438,10 @@ -(BOOL)isReachableViaWWAN

SCNetworkReachabilityFlags flags = 0;

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
if(SCNetworkReachabilityGetFlags(self.reachabilityRef, &flags))
#pragma clang diagnostic pop
{
// Check we're REACHABLE
if(flags & kSCNetworkReachabilityFlagsReachable)
Expand Down
Loading