Suppress SCNetworkReachability deprecation warnings#1430
Closed
bmehta001 wants to merge 1 commit into
Closed
Conversation
Add pragma to suppress SCNetworkReachability deprecation warnings in ODWReachability.m. These APIs (SCNetworkReachabilityCreateWithName, SCNetworkReachabilityCreateWithAddress) were deprecated in iOS 17.4 and trigger -Werror build failures in Xcode 26.4+. A full migration to NWPathMonitor is tracked separately; this unblocks the build. Fixes microsoft#1425 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
bmehta001
force-pushed
the
bhamehta/issue-1425-off-1418
branch
from
2efd18f to
b4a3fa3
Compare
Contributor
Author
|
Superseded by a proper NWPathMonitor migration instead of pragma suppression. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a file-level pragma to suppress all SCNetworkReachability deprecation warnings in ODWReachability.m. This entire file is a third-party reachability wrapper that uses these APIs pervasively (50+ call sites). The APIs were deprecated in iOS 17.4 and trigger
-Werrorbuild failures in Xcode 26.4+.A single file-level suppression is cleaner than wrapping each individual call site (the file already had ~15 per-site pragma pairs from earlier fixes).
A full migration to
NWPathMonitoris tracked separately; this unblocks the build.Fixes #1425