refactor(website): use maxSequencesPerEntry that's already used by backend to simplify #5631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
added
website
anna-parker
reviewed
Dec 4, 2025
Contributor
anna-parker
left a comment
anna-parker
left a comment
There was a problem hiding this comment.
of the top of my head I created a function called isMultiSegmentedOrganism on the website before we added the maxSequencesPerEntry field - this should probably be refactored as well - but I think this can also happen after we merge the feature branch
Contributor
Author
|
Yeah this is no longer needed now - I'll add all the simplifications to this PR, give me one sec |
anna-parker
reviewed
Dec 4, 2025
anna-parker
reviewed
Dec 4, 2025
anna-parker
reviewed
Dec 4, 2025
anna-parker
reviewed
Dec 4, 2025
anna-parker
reviewed
Dec 4, 2025
anna-parker
reviewed
Dec 4, 2025
anna-parker
force-pushed
the
edit-page-anya
branch
from
bce2b8a to
2213cec
Compare
anna-parker
force-pushed
the
use-max-sequences-per-entry
branch
from
20a5c74 to
163db58
Compare
corneliusroemer
force-pushed
the
use-max-sequences-per-entry
branch
3 times, most recently
from
09b5a50 to
17d320f
Compare
corneliusroemer
commented
Dec 5, 2025
anna-parker
reviewed
Dec 5, 2025
anna-parker
reviewed
Dec 5, 2025
Contributor
anna-parker
left a comment
anna-parker
left a comment
There was a problem hiding this comment.
I found a bug when downloading the csv file - all rows are appended without creating a new line
Screen.Recording.2025-12-05.at.17.07.28.mov
anna-parker
reviewed
Dec 5, 2025
anna-parker
approved these changes
Dec 5, 2025
Contributor
anna-parker
left a comment
anna-parker
left a comment
There was a problem hiding this comment.
please add my bug fix before merging :-)
…ckend to simplify Fix test and add new one so all cases are covered Make more readable Remove now unused function Further simplifications removing getreferenceGenomeLightweightSchema when no longer needed now Resolve #3984 Remove unnecessary lightweight schema in more places Apply suggestions from code review Co-authored-by: Anna (Anya) Parker <50943381+anna-parker@users.noreply.github.com> Dummy for builds (cherry picked from commit 69a4836) # Conflicts: # website/src/components/Edit/SequencesForm.spec.tsx Merge conflicts and use constants consistenly Update website/src/components/Edit/SequencesForm.spec.tsx # Conflicts: # website/src/components/Edit/EditableSequences.spec.ts # website/src/components/Edit/SequencesForm.tsx # website/src/components/Submission/FormOrUploadWrapper.tsx
corneliusroemer
force-pushed
the
use-max-sequences-per-entry
branch
from
1a0454f to
08abc49
Compare
maverbiest
pushed a commit
that referenced
this pull request
Dec 8, 2025
…ckend to simplify (#5631) We now have maxSequencesPerEntry explicitly set in submissionDataTypes per organism (see #5559) Makes sense to use this in website code as well when applicable to simplify (there might be more places where it could be used). Tested submission on preview ### PR Checklist - [x] The implemented feature is covered by appropriate, automated tests. - [x] Any manual testing that has been done is documented (i.e. what exactly was tested?) 🚀 Preview: https://use-max-sequences-per-ent.loculus.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have maxSequencesPerEntry explicitly set in submissionDataTypes per organism (see #5559)
Makes sense to use this in website code as well when applicable to simplify (there might be more places where it could be used).
Tested submission on preview
PR Checklist
🚀 Preview: https://use-max-sequences-per-ent.loculus.org