Open
Conversation
hariharan-devarajan
force-pushed
the
checkpoint/02-02-26-new
branch
9 times, most recently
from
3c471ae to
44b0ed7
Compare
1. Enhance argument parsing and logging, add UTF-8 character removal, and update dependency handling 2. Tested Lustre configurations 3. Improved validation case to handle all cases 4. reduced logging to avoid blowing up log files
1. Generalized scheduler implementation to be updated by any user. 2. Specialized implementation for prolog and epilog script for slurm and flux and general.
…xisting probes from JSON
1. Build instructions 2. Required dependencies 3. Deployment options
hariharan-devarajan
force-pushed
the
checkpoint/02-02-26-new
branch
from
44b0ed7 to
f2f4d17
Compare
hariharan-devarajan
force-pushed
the
checkpoint/02-02-26-new
branch
from
f2f4d17 to
f6a8428
Compare
milroy
reviewed
Feb 5, 2026
cmake/modules/datacrumbs-utils.cmake
Outdated
| get_filename_component(json-c_INCLUDE_DIR "${json-c_DIR}/../../../include" ABSOLUTE) | ||
| get_filename_component(json-c_LIBRARY_DIR "${json-c_DIR}/../../" ABSOLUTE) | ||
| include_directories(json-c::json-c) | ||
| include_directories(${json-c_INCLUDE_DIR}) |
Collaborator
There was a problem hiding this comment.
Investigate JSON-C package config.
Member
Author
There was a problem hiding this comment.
I tried across different version on different os version, this is very unreliable. I will keep it like this for now.
milroy
reviewed
Feb 5, 2026
|
|
||
| std::cout << "\n"; | ||
| std::cout << "╔════════════════════════════════════════════════════════════════════════════╗\n"; | ||
| std::cout << "║ INVALID PROBES BY CATEGORY ║\n"; |
Collaborator
There was a problem hiding this comment.
Suggested change
| std::cout << "║ INVALID PROBES BY CATEGORY ║\n"; | |
| std::cout << "║ INVALID PROBES BY CATEGORY ║\n"; |
milroy
reviewed
Feb 5, 2026
| match-leak-kinds: definite,indirect | ||
| ... | ||
| fun:pthread_* | ||
| } No newline at end of file |
milroy
reviewed
Feb 12, 2026
cmake/modules/datacrumbs-utils.cmake
Outdated
| if (DATACRUMBS_SCHEDULER_JOBID_ENV_VAR STREQUAL "NONE") | ||
| if(DATACRUMBS_SCHEDULER_TYPE STREQUAL "SLURM") | ||
| set(DATACRUMBS_SCHEDULER_JOBID_ENV_VAR "SLURM_JOB_ID") | ||
| elseif(DATACRUMBS_SCHEDULER_TYPE STREQUAL "OPENMPI") |
Collaborator
There was a problem hiding this comment.
Consider DATACRUMBS_LAUNCHER_TYPE.
milroy
reviewed
Feb 12, 2026
| fi | ||
|
|
||
| info "salloc ${DATACRUMBS_ARGS[*]}" | ||
| exec salloc "${DATACRUMBS_ARGS[@]}" |
milroy
reviewed
Mar 5, 2026
| readonly DATACRUMBS_USER | ||
| fi | ||
|
|
||
| if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then |
Collaborator
There was a problem hiding this comment.
Need to keep readonly here.
Suggested change
| if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then | |
| readonly DATACRUMBS_IS_ROOT | |
| readonly DATACRUMBS_USER | |
| fi | |
| if [[ "${DATACRUMBS_ENV_LOADED:-0}" == "0" ]]; then |
milroy
reviewed
Mar 5, 2026
| file(MAKE_DIRECTORY ${CMAKE_DATA_OUTPUT_DIRECTORY}) | ||
|
|
||
| if(_DATACRUMBS_DATA_FILES) | ||
| install(FILES ${_DATACRUMBS_DATA_FILES} |
Collaborator
There was a problem hiding this comment.
Completed this commit on 3/5/2026
- Formatting on probe_validator.cpp - Change DATACRUMBS_SCHEDULER_TYPE -> DATACRUMBS_LAUNCHER_TYPE - Make DATACRUMBS_IS_ROOT and DATACRUMBS_USER readonly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.